Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dots get propagated into invalid names #1062

Closed
rcmorano opened this issue Aug 11, 2018 · 0 comments
Closed

dots get propagated into invalid names #1062

rcmorano opened this issue Aug 11, 2018 · 0 comments

Comments

@rcmorano
Copy link
Contributor

rcmorano commented Aug 11, 2018

Aloha,

I've been converting some compose files to Helm charts (concretely DAppNode's project ones) and ran into the same problem exposed in #420.
In fact it's the last comment from @xiaoping378 in this issue.

I've created #1063 PR following the guidelines of previous PRs #509 and #569 which fixed the problem and added the needed warning bits to documentation.
I Hope you find it's suitable to merge or as base for future work on the issue :)

Best!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants