Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixtures directory has README.md that are incomplete or inconsistent #177

Closed
surajssd opened this issue Sep 28, 2016 · 4 comments
Closed

Comments

@surajssd
Copy link
Member

The test scripts from fixtures has README.md which has info of how to run those examples with docker-compose we can add info of using it with kompose.

These fixtures directories have no README.md at all.

@kadel
Copy link
Member

kadel commented Sep 28, 2016

Is it necessary for test fixtures to have README?
entrypoint-commmand and ports-with-proto are not even meaningful applications

@surajssd
Copy link
Member Author

I just wanted to make sure that these apps work when deployed so that end-to-end still works when we do kompose up on them!

@sebgoa
Copy link
Contributor

sebgoa commented Oct 5, 2016

@surajssd I hear you..but some of these docker-compose files will most likely break at some point. The ether pad one for example uses a mariad db container without an image tag...so latest might change underneath you at some point.

  • image tags are not immutable anyway.

So technically we should actually verify that the docker-compose files actually give a working app...

@surajssd
Copy link
Member Author

surajssd commented Jan 4, 2017

i don't think this is required/valid so closing it.

@surajssd surajssd closed this as completed Jan 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants