Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests based on current issues #205

Closed
sebgoa opened this issue Oct 12, 2016 · 4 comments
Closed

Add tests based on current issues #205

sebgoa opened this issue Oct 12, 2016 · 4 comments

Comments

@sebgoa
Copy link
Contributor

sebgoa commented Oct 12, 2016

That fail due to libcompose v2 support...

Add wiki page and keep track of tests.

@ericchiang
Copy link

kompose could definitely use more unit test. I only see two on HEAD.

I've seen a ton of PRs be merged without unit tests. Most of the work of adding new features is proper testing to prevent regressions and help reviewers have confidence in changes. It might be a reasonable idea to start enforcing tests as part of PRs as well.

$ go test -race -cover -v $( go list github.com/kubernetes-incubator/kompose/... | grep -v '/vendor/' )
?       github.com/kubernetes-incubator/kompose [no test files]
=== RUN   TestParseVolume
--- PASS: TestParseVolume (0.00s)
PASS
coverage: 0.0% of statements
ok      github.com/kubernetes-incubator/kompose/cli/app 1.128s  coverage: 0.0% of statements
?       github.com/kubernetes-incubator/kompose/cli/command [no test files]
?       github.com/kubernetes-incubator/kompose/pkg/kobject [no test files]
?       github.com/kubernetes-incubator/kompose/pkg/loader  [no test files]
?       github.com/kubernetes-incubator/kompose/pkg/loader/bundle   [no test files]
?       github.com/kubernetes-incubator/kompose/pkg/loader/compose  [no test files]
?       github.com/kubernetes-incubator/kompose/pkg/transformer [no test files]
=== RUN   TestKomposeConvert
--- PASS: TestKomposeConvert (0.00s)
    kubernetes_test.go:215: Test case: Convert to Deployments (D)
    kubernetes_test.go:215: Test case: Convert to DaemonSets (DS)
    kubernetes_test.go:215: Test case: Convert to ReplicationController (RC)
    kubernetes_test.go:215: Test case: Convert to D, DS, and RC
PASS
coverage: 40.5% of statements
ok      github.com/kubernetes-incubator/kompose/pkg/transformer/kubernetes  1.095s  coverage: 40.5% of statements
?       github.com/kubernetes-incubator/kompose/pkg/transformer/openshift   [no test files]
?       github.com/kubernetes-incubator/kompose/version [no test files]

@cdrage
Copy link
Member

cdrage commented Oct 31, 2016

@ericchiang That looks like a way better command to use to add to unit tests, perhaps we add this to the current make test-unit command we have?

@cdrage
Copy link
Member

cdrage commented Oct 31, 2016

I created PR #261 for this ^^

@surajssd
Copy link
Member

i think we are doing good on this, so closing it. Thanks @surajnarwade for bringing this to my notice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants