Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support docker bundles format as input #4

Closed
sebgoa opened this issue Jul 1, 2016 · 10 comments
Closed

Support docker bundles format as input #4

sebgoa opened this issue Jul 1, 2016 · 10 comments
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/P1

Comments

@sebgoa
Copy link
Contributor

sebgoa commented Jul 1, 2016

No description provided.

@ngtuna ngtuna added kind/feature Categorizes issue or PR as related to a new feature. v0.0.1 priority/P1 and removed v0.0.1 labels Jul 5, 2016
@ngtuna
Copy link
Contributor

ngtuna commented Jul 6, 2016

moby/moby#23522

@ngtuna
Copy link
Contributor

ngtuna commented Jul 6, 2016

There is an issue with package github.com/docker/docker/api/client/bundlefile: at this moment it is marked // +build experimental. That means go can't see it as a normal lib thus the building is fail.

$ go build -o kompose2 ./cli/main  
cli/app/app.go:30:2: no buildable Go source files in ...github.com/docker/docker/api/client/bundlefile

@sebgoa
Copy link
Contributor Author

sebgoa commented Jul 6, 2016

I think this library allows you to generate bundles from compose file. We might add that.

But what we want is to be able to take a bundle and transform it into k8s primitives. It might be tricky because the image reference in a bundle is the sha of the layer...and not the image tag (which is not immutable).

@ngtuna
Copy link
Contributor

ngtuna commented Jul 7, 2016

No Sebastien, that lib supports us to take a dab file and parse to Bundlefile struct. Then we are able to map to k8s objects.

Yes you're right. Image reference would be a tricky point.

@sebgoa
Copy link
Contributor Author

sebgoa commented Jul 7, 2016

ok good to know.

as a first pass, we might just extract an image name from docker hub and use the latest tag. Since k8s does not support referencing specific layers in the image field.

@ngtuna
Copy link
Contributor

ngtuna commented Jul 13, 2016

Working on dab-support branch

@ngtuna
Copy link
Contributor

ngtuna commented Jul 13, 2016

@Runseb Figure out the current revision of libcompose is too old in order to support mapping bundles fields to compose fields then to k8s primitives... This's such a pain if we keep enforcing it. I'm going to level up libcompose revision. It should be good as we can solve #11 in the meantime.

@sebgoa
Copy link
Contributor Author

sebgoa commented Jul 13, 2016

you mean update the godeps hash for lib compose ?
will this break the current code ?

@ngtuna
Copy link
Contributor

ngtuna commented Jul 14, 2016

Correct. No it doesn't harm the current code much. But I keep master branch stable and mainly work in separate dab-support branch. Then we can decide to merge when it done.

@ngtuna
Copy link
Contributor

ngtuna commented Jul 21, 2016

Closed by 91d9818

@ngtuna ngtuna closed this as completed Jul 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/P1
Projects
None yet
Development

No branches or pull requests

2 participants