Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong version (0.1.2) in "kompose versione" (instead of 0.2.0) #411

Closed
pivulic opened this issue Feb 5, 2017 · 7 comments
Closed

Wrong version (0.1.2) in "kompose versione" (instead of 0.2.0) #411

pivulic opened this issue Feb 5, 2017 · 7 comments

Comments

@pivulic
Copy link

pivulic commented Feb 5, 2017

Problem

I'm having the same issue as http://stackoverflow.com/questions/41738374/kubernestes-persistentvolumeclaim-is-not-bound, but thought I should upgrade from 0.1.2 to 0.2.0.

However, running kompose version displays 0.1.2 (HEAD) instead of 0.2.0

How To Recreate

Following the Mac OS steps:

chmod +x kompose
sudo mv ./kompose /usr/local/bin/kompose
kompose version

Same result if I run:

cd /usr/local/bin/
./kompose version

Actual Result

0.1.2 (HEAD)

Expected Result

0.2.0

@surajnarwade
Copy link
Contributor

surajnarwade commented Feb 6, 2017

Regarding your issue, you should have created persistent volume before claiming, for reference: https://kubernetes.io/docs/user-guide/persistent-volumes/

this works for me:
$ kompose version
0.2.0 (64433fd)

@cdrage
Copy link
Member

cdrage commented Feb 6, 2017

@surajnarwade @pivulic

Looks like I created the binaries incorrectly (did not sync with master before release, boo on me!).

I'll update them so it actually shows 0.2.0 as the expected result on kompose version.

In regards to volumes, @surajnarwade is correct that you need to create a Persistent Volume before using PersistentVolumeClaim.

@cdrage
Copy link
Member

cdrage commented Feb 6, 2017

@pivulic Release has been updated to include the proper kompose version output.

Mind checking it again? :)

@cdrage
Copy link
Member

cdrage commented Feb 8, 2017

Going to close this for now as I was able to confirm that the version works with the new binary!

@cdrage cdrage closed this as completed Feb 8, 2017
@pivulic
Copy link
Author

pivulic commented Feb 8, 2017

Thanks @cdrage! (and sorry for the late reply) Works perfectly! 👍

Regarding creating a Persistent Volume, I looked through the guide, but isn't kompose up supposed to take care of it, if my docker-compose.yml file already has the volumes configured?

Let me know if I should create a separate issue for this, or if you can refer me somewhere else :)

@surajssd
Copy link
Member

surajssd commented Feb 9, 2017

@pivulic thanks for the issue and about kompose generating PVs by default:

it might feel like kompose should take care of this but the problem here is that PV can only be created by user with system:admin privileges, and there are multiple ways to create PV with various backends, now kompose might not know beforehand what is the type of cluster(minikube where hostPath can be used, multi-node cluster with admin access, cluster with only nfs, openshift online, etc.) a user is gonna deploy application on. So a generated PV might not always work, with different clusters.

Kompose tries to generate configs which are cluster neutral, I mean they will work on any cluster. But generating configs which need cluster info can be little hard to do.

But in case anyone has better way of doing that it would be awesome, I cannot think of any as of now.

@cdrage
Copy link
Member

cdrage commented Feb 9, 2017

Yeah, we're going to improve how we convert volumes in terms of logging as well as documentation, it's the biggest thorn when converting at the moment as they don't exactly translate 1-1 with Kubernetes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants