Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest kompose fails on many build-config tests locally #585

Closed
surajssd opened this issue May 2, 2017 · 5 comments
Closed

Latest kompose fails on many build-config tests locally #585

surajssd opened this issue May 2, 2017 · 5 comments

Comments

@surajssd
Copy link
Member

surajssd commented May 2, 2017

Building kompose

✘-127 ~/go/src/github.com/kubernetes-incubator/kompose [master L|✔]
17:14 $ make install
go install -ldflags="-w -X github.com/kubernetes-incubator/kompose/cmd.GITCOMMIT=abf8192"~/go/src/github.com/kubernetes-incubator/kompose [master L|✔]
17:15 $ kompose version
0.6.0 (abf8192)

Running tests:

~/go/src/github.com/kubernetes-incubator/kompose [master L|✔]
17:15 $ make test-cmd
./script/test/cmd/tests.sh


===> Starting test <===
convert::expect_failure: Running: 'kompose -f /home/hummer/go/src/github.com/kubernetes-incubator/kompose/script/test/fixtures/etherpad/docker-compose.yml convert --stdout'
PASS: errored out with exit status: 1

[SNIP]

===> Starting test <===
convert::expect_success_and_warning: Running: 'kompose --provider=openshift -f /home/hummer/go/src/github.com/kubernetes-incubator/kompose/script/test/fixtures/nginx-node-redis/docker-compose.yml convert --stdout -j' expected_output: '/home/hummer/go/src/github.com/kubernetes-incubator/kompose/script/test/fixtures/nginx-node-redis/output-os.json' expected_warning: 'Buildconfig using https://github.com/kubernetes-incubator/kompose.git::HEAD as source.'
FAIL: converted output does not match

Above failed.

Below one failed

[SNIP]

===> Starting test <===
convert::expect_success_and_warning: Running: 'kompose convert --provider openshift --stdout -j' expected_output: '/home/hummer/go/src/github.com/kubernetes-incubator/kompose/script/test/fixtures/nginx-node-redis/output-os.json' expected_warning: 'Buildconfig using https://github.com/kubernetes-incubator/kompose.git::HEAD as source.'
FAIL: converted output does not match


===> Starting test <===
convert::expect_success_and_warning: Running: 'kompose convert --provider openshift --stdout -j -f nginx-node-redis/docker-compose.yml' expected_output: '/home/hummer/go/src/github.com/kubernetes-incubator/kompose/script/test/fixtures/nginx-node-redis/output-os.json' expected_warning: 'Buildconfig using https://github.com/kubernetes-incubator/kompose.git::HEAD as source.'
FAIL: converted output does not match


===> Starting test <===
convert::expect_success_and_warning: Running: 'kompose convert --provider openshift --stdout -j -f ../docker-compose.yml' expected_output: '/home/hummer/go/src/github.com/kubernetes-incubator/kompose/script/test/fixtures/nginx-node-redis/output-os.json' expected_warning: 'Buildconfig using https://github.com/kubernetes-incubator/kompose.git::HEAD as source.'
FAIL: converted output does not match

[SNIP]

===> Starting test <===
convert::expect_success: Running: 'kompose --provider=openshift convert --stdout -j' expected_output: '/home/hummer/go/src/github.com/kubernetes-incubator/kompose/script/test/fixtures/yaml-and-yml/yml/output-os.json'
PASS: converted output matches
Makefile:67: recipe for target 'test-cmd' failed
make: *** [test-cmd] Error 1

How is this one passing on travis or for anyone else on their machines?

@ashetty1
Copy link
Contributor

ashetty1 commented May 2, 2017

@surajssd It doesn't fail on travis because travis does a git fetch on PRs. So "expected_warning: 'Buildconfig using https://github.com/kubernetes-incubator/kompose.git::HEAD as source.' " works on travis, but not when you are checked into master.

@surajssd
Copy link
Member Author

surajssd commented May 3, 2017

What is the solution so that i have all local tests passing?

@ashetty1
Copy link
Contributor

ashetty1 commented May 3, 2017

@surajssd see if running on detached HEAD works

@surajnarwade
Copy link
Contributor

@surajssd , this PR #577 will sove this issue

@surajssd
Copy link
Member Author

surajssd commented May 9, 2017

closed via #577

@surajssd surajssd closed this as completed May 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants