Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should validate for duplicated zone at API level #606

Closed
justinsb opened this issue Oct 6, 2016 · 5 comments
Closed

Should validate for duplicated zone at API level #606

justinsb opened this issue Oct 6, 2016 · 5 comments
Milestone

Comments

@justinsb
Copy link
Member

justinsb commented Oct 6, 2016

If you're going through the API, you can do this: us-east-1c,us-east-1c

@justinsb
Copy link
Member Author

justinsb commented Oct 6, 2016

Though it is caught on update: Zones contained a duplicate value: us-east-1c

@chrislovecnm
Copy link
Contributor

What unit testing are we doing to validate that we have clean data sent through the api?

@chrislovecnm
Copy link
Contributor

I am looking through issues to test against #1183

@chrislovecnm
Copy link
Contributor

See #1206 ~ The PR is in. Who can test?

@justinsb justinsb added this to the 1.5.0 milestone Dec 28, 2016
@justinsb
Copy link
Member Author

This is now caught:

spec: Invalid value: [{"name":"us-east-1a","zone":"us-east-1a","cidr":"172.20.32.0/19","type":"Public"},{"name":"us-east-1a","zone":"us-east-1a","cidr":"172.20.64.0/19","type":"Public"},{"name":"us-east-1a","zone":"us-east-1a","cidr":"172.20.96.0/19","type":"Public"}]: subnets with duplicate name "us-east-1a" found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants