Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WeaveNet EXTRA_ARGS support #7390

Closed
ReillyTevera opened this issue Aug 8, 2019 · 2 comments · Fixed by #8265
Closed

Add WeaveNet EXTRA_ARGS support #7390

ReillyTevera opened this issue Aug 8, 2019 · 2 comments · Fixed by #8265

Comments

@ReillyTevera
Copy link
Contributor

1. Describe IN DETAIL the feature/behavior/change you would like to see.
We have multiple kubernetes clusters that import all cluster logs to a logging service. Weave-net and weave-npc generate very large volumes of logs in our environment which causes us to use up our daily quote faster than desired.

Weave net supports modifying the log level through the --log-level= command line argument and allows you to pass in this argument via the EXTRA_ARGS environmental variable. It would be nice if we could support this feature in Kops through addition to the Weave networking spec.

Unfortunately weave-npc does not yet support this but I have added weaveworks/weave#3683 and once that or some variant of it is merged and a release of weave-net is cut we can add the environmental variable to weave-npc as well.

2. Feel free to provide a design supporting your feature request.

  • I propose we add NetExtraArgs to the WeaveNetworkingSpec and when this is present add the EXTRA_ARGS to the weave-net container template
  • NpcExtraArgs would be added at a later date to do the same with weave-npc
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 6, 2019
@ReillyTevera
Copy link
Contributor Author

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants