Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kops API/Swagger Spec #815

Closed
krisnova opened this issue Nov 5, 2016 · 8 comments
Closed

Kops API/Swagger Spec #815

krisnova opened this issue Nov 5, 2016 · 8 comments
Labels
area/documentation lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Milestone

Comments

@krisnova
Copy link
Contributor

krisnova commented Nov 5, 2016

So now that we have a lovely kops API - I think we should get in the habit of documenting it. I think we should follow the kubernetes approach and generate a swagger spec/contract.

It would be great to look at generating a spec/contract from our go code as well! (I know, generating code that generates documentation.. right?) But having the notes from the API definition in go would be very valuable here!

My thought was to have a make target to support this

make docs

We could begin fleshing the target out with swagger functionality and autogen functionality for our documentation in general..

Wins:

  1. Precursor for a kops website/.io
  2. High level view into kops from a library/api perspective
  3. Once we begin work on the HTTP layer, having this will almost be a must
  4. Encouragement to write better code
  5. Everybody loves API docs
@chrislovecnm
Copy link
Contributor

So API docs make sense. With the swagger we need to figure out how we are making an API outa this :) If we embed this into the K8s API server, it may gen the swagger for us. Not sure.

@chrislovecnm
Copy link
Contributor

We have PR inbound thay may help with this ... I am looking through issues to test against #1183

This can get us a swagger ... Any thing else?

@chrislovecnm
Copy link
Contributor

Removing from #1206

@justinsb justinsb added this to the backlog milestone Dec 28, 2016
@chrislovecnm
Copy link
Contributor

We have this with the API server, can we close now?

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

Prevent issues from auto-closing with an /lifecycle frozen comment.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or @fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 12, 2018
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten
/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Feb 12, 2018
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

@punit-naik
Copy link

Can anyone post the link for swagger spec json here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

6 participants