Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove vsphere cloud provider #9177

Merged
merged 2 commits into from Jun 1, 2020
Merged

Remove vsphere cloud provider #9177

merged 2 commits into from Jun 1, 2020

Conversation

olemarkus
Copy link
Member

Fixes #9166

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 25, 2020
@olemarkus olemarkus force-pushed the remove-vsphere branch 2 times, most recently from 4181230 to d33b317 Compare May 25, 2020 18:43
@hakman
Copy link
Member

hakman commented May 25, 2020

@olemarkus Could you split the vendor code into a separate commit? Should make it easier to review.

@olemarkus
Copy link
Member Author

Certainly. Better now?

@hakman
Copy link
Member

hakman commented May 25, 2020

Yes, looks better. Thanks!

@hakman
Copy link
Member

hakman commented May 25, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 25, 2020
johngmyers
johngmyers requested changes May 25, 2020
View reviewed changes
upup/pkg/fi/cloudup/dns.go
@@ -166,22 +166,6 @@ func precreateDNS(ctx context.Context, cluster *kops.Cluster, cloud fi.Cloud) er
}

recordsMap := make(map[string]dnsprovider.ResourceRecordSet)
// vSphere provider uses CoreDNS, which doesn't have rrs.List() function supported.
// Thus we use rrs.Get() to check every dnsHostname instead
if cloud.ProviderID() != kops.CloudProviderVSphere {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a != comparison, so the body should become unconditional, not be removed.

zetaab
zetaab requested changes May 26, 2020
View reviewed changes
Copy link
Member

@zetaab zetaab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix that one thing and we are good to go from my point of view

@rifelpet
Copy link
Member

I posted in the issue, but i think its worth waiting a few days for responses before we continue with the removal just to be sure.

#9166 (comment)

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 26, 2020
@olemarkus
Copy link
Member Author

/hold

If all looks good, it would be nice to get approval.
I'll remove the hold if there is no response in #9166 after the weekend.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 26, 2020
@rifelpet
Copy link
Member

👍
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: olemarkus, rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 26, 2020
@hakman
Copy link
Member

hakman commented May 26, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels May 26, 2020
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels May 30, 2020
@hakman
Copy link
Member

hakman commented May 30, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 30, 2020
@olemarkus
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 1, 2020
@k8s-ci-robot k8s-ci-robot merged commit 7b06798 into kubernetes:master Jun 1, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Jun 1, 2020
@olemarkus olemarkus deleted the remove-vsphere branch June 3, 2020 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johngmyers johngmyers johngmyers requested changes

@zetaab zetaab zetaab requested changes

@hakman hakman Awaiting requested review from hakman

Assignees

@hakman hakman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/api area/documentation area/nodeup cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v1.18
Development

Successfully merging this pull request may close these issues.

Remove vsphere support
6 participants
@olemarkus @hakman @rifelpet @k8s-ci-robot @johngmyers @zetaab