Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change api server livenessProbe toi livez from healthz #9977

Closed
grosser opened this issue Sep 21, 2020 · 3 comments
Closed

change api server livenessProbe toi livez from healthz #9977

grosser opened this issue Sep 21, 2020 · 3 comments

Comments

@grosser
Copy link

grosser commented Sep 21, 2020

https://kubernetes.io/docs/reference/using-api/health-checks/#api-endpoints-for-health says that healthz is deprecated, so it would be nice to stop using it ... not sure how much work that is though.
Not producing any issues, just saw that while reading the docs.

@mmerrill3
Copy link
Contributor

@grosser I see two areas of change. One is the addition of new arguments to the API server to configure settings for livez. This includes adding new yaml configuration for the APIServer and implementing the options at the command line for the appropriate k8s version. This would be updates to API protocolbuffers for kops, documentation, and changing the task to create the API server's launch options. Testing as well.
The other is the changes in the health check sidecar that is used by kops (#9069) so it can pass through livez requests.

I think it would be a medium/large effort.

@mmerrill3
Copy link
Contributor

The sidecar will pass through requests to livez from the PR: (#9069)

Are you aiming to be able to set configuration for the livez check in the api server, like --livez-grace-period?

@grosser
Copy link
Author

grosser commented Sep 29, 2020

wow thx for the info ... I'd say that's more work then I hoped for ... so let's let this sit until the endpoint actually goes away :)

@grosser grosser closed this as completed Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants