Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take field modifications into account in CRS configurations #2262

Open
rexagod opened this issue Dec 10, 2023 · 1 comment
Open

Take field modifications into account in CRS configurations #2262

rexagod opened this issue Dec 10, 2023 · 1 comment
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@rexagod
Copy link
Member

rexagod commented Dec 10, 2023

What happened: Suppose a CR that may append fields conditionally, for eg. VPAs. For the the transient duration that it takes for the autoscaling pipeline to provide recommendations, the condition field is nil, and thus, as a result, any configurations depending on this field will cause KSM to log errors repeatedly until those fields are appended.

What you expected to happen: No error logs, and even if there were, should point out exactly which resource was causing the transient error(s) (some VPAs may be initialized sooner or later than others).

How to reproduce it (as minimally and precisely as possible): Enable KSM and use the CRS featureset on VPAs.

@rexagod rexagod added the kind/bug Categorizes issue or PR as related to a bug. label Dec 10, 2023
@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Dec 10, 2023
@logicalhan
Copy link
Member

/triage accepted
/assign @rexagod

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

3 participants