Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Make kube-state-metrics a library #579

Closed
lilic opened this issue Nov 8, 2018 · 4 comments · Fixed by #632
Closed

Feature: Make kube-state-metrics a library #579

lilic opened this issue Nov 8, 2018 · 4 comments · Fixed by #632
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@lilic
Copy link
Member

lilic commented Nov 8, 2018

Is this a BUG REPORT or FEATURE REQUEST?:
/kind feature

What:
This is a follow up from #575. Some functions were exposed in that PR, but would like to continue the disucsion to make more of a usuable library.

How:

pkg
├── collector // functions needed to create a collector, this would be used in the builder pkg and externally 
├── internal
│   └── builder // content of the current upstream resource collectors which would consume the collector pkg
├── metrics // what is currently there but also move the utils/helper functions from collectors. Also the metricHandler interface as that would be useful to expose and reuse elsewhere.

cc @mxinden @brancz

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 8, 2018
@lilic
Copy link
Member Author

lilic commented Jan 7, 2019

@mxinden @brancz Any thoughts on the above? I would be willing to do the work on this. :) Thanks!

@brancz
Copy link
Member

brancz commented Jan 7, 2019

Moving anything that is not lib or main to an internal package sounds like a good idea. I think I would like to hold off on rearranging before the final v1.5.0 release (which we should be cutting rather soon). How does that sound?

@mxinden
Copy link
Contributor

mxinden commented Jan 14, 2019

With v1.5.0 cut, I am happy to review the refactoring suggested above. Feel free to ping me @lilic on the PR.

@mxinden
Copy link
Contributor

mxinden commented Jan 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants