Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support a --dry-run mode for all kubeadm functions #389

Closed
luxas opened this issue Aug 15, 2017 · 1 comment · Fixed by kubernetes/kubernetes#50631 or kubernetes/kubernetes#51122
Closed
Assignees
Labels
area/UX priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Milestone

Comments

@luxas
Copy link
Member

luxas commented Aug 15, 2017

Generally, all POST/PUT/PATCH/DELETEs, etc must be discarded in dry-run mode

On kubeadm init, all GET/LISTs will be faked; it will return values that it knows are valid to get the kubeadm init flow working well in dry-run mode.
On kubeadm token, join, upgrade where we can access an API server; it will proxy the GET/LIST to that API Server to get real values for kubeadm to react on.

Regarding the filesystem; a temporary directory will be used for writing files. Then the content will be printed and the temp directory removed

@luxas luxas self-assigned this Aug 15, 2017
@luxas luxas added area/UX kind/enhancement priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Aug 15, 2017
@luxas luxas added this to the v1.8 milestone Aug 15, 2017
@luxas
Copy link
Member Author

luxas commented Aug 22, 2017

This is not yet fully fixed, sending a PR now...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/UX priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
1 participant