Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DockerValidator should use the CRI, not the Docker API #533

Closed
runcom opened this issue Nov 9, 2017 · 4 comments
Closed

DockerValidator should use the CRI, not the Docker API #533

runcom opened this issue Nov 9, 2017 · 4 comments

Comments

@runcom
Copy link

runcom commented Nov 9, 2017

The DockerValidator in https://github.com/kubernetes/kubernetes/blob/master/test/e2e_node/system/docker_validator.go which is used by kubeadm preflights checks is using the Docker API directly. With kubernetes/kubernetes#55055 we're moving dockerisms to use crictl and the CRI. The DockerValidator should use crictl to gather Docker version via the CRI Version endpoint. However, the CRI isn't exposing the docker graphdriver (hence the need for an issue to track). We need to understand if and how those additional info are to be exported by the CRI.

/cc @luxas @Random-Liu @feiskyer

@luxas
Copy link
Member

luxas commented Nov 9, 2017

@runcom I actually think this issue would fit better in the kubernetes/kubernetes repo as this is a general improvement suggestion to the system verification check owned by sig-node and they track their issue in the main repo. WDYT? Can you reopen there possibly and tag (@)kubernetes/sig-node-bugs?

@runcom
Copy link
Author

runcom commented Nov 9, 2017

Yup! Will do

@luxas luxas closed this as completed Nov 9, 2017
@luxas
Copy link
Member

luxas commented Jun 30, 2018

@runcom did you ever file an issue for this? I don't see it linked here?

@luxas
Copy link
Member

luxas commented Jun 30, 2018

nvm found it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants