Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubectl debug: Add integration and unit tests for new profiles #1372

Closed
ardaguclu opened this issue Feb 16, 2023 · 5 comments
Closed

kubectl debug: Add integration and unit tests for new profiles #1372

ardaguclu opened this issue Feb 16, 2023 · 5 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@ardaguclu
Copy link
Member

What would you like to be added:
New profiles were added into kubectl debug command.
We need to add more integration tests for these profiles into https://github.com/kubernetes/kubernetes/blob/master/test/cmd/debug.sh

We need to add more unit tests for these profiles in TestGeneratePodCopyWithDebugContainer
and TestGenerateNodeDebugPod functions. EphemeralContainer unit tests are already
covering these profiles.

Why is this needed:
To increase confidence and prevent possible regressions in the future.
@ardaguclu ardaguclu added the kind/feature Categorizes issue or PR as related to a new feature. label Feb 16, 2023
@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Feb 16, 2023
@ardaguclu
Copy link
Member Author

/triage accepted
/priority backlog
/cc @verb

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/backlog Higher priority than priority/awaiting-more-evidence. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 16, 2023
@ardaguclu
Copy link
Member Author

@sding3 @wedaly
Would you be interested in working on this?

@ardaguclu ardaguclu mentioned this issue Feb 16, 2023
Merged
@ardaguclu
Copy link
Member Author

This kubernetes/kubernetes#115839 covers the unit tests. Thanks @wedaly

@ardaguclu ardaguclu mentioned this issue Feb 20, 2023
Closed
@sding3
Copy link
Contributor

sding3 commented Mar 1, 2023

@ardaguclu - friendly ping on kubernetes/kubernetes#115909

@ardaguclu
Copy link
Member Author

I think we can close this issue, since integration and unit tests were added in referenced PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ardaguclu @sding3 @k8s-ci-robot