You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In the test framework MVP (discussed in #87 ), there is currently a tight coupling between the test fakes pkg/frameworks/test/assets/fakeetcd/ and etcd.go. In particular, both of these currently know the exact flags that etcd ought to be called with. There is a similar issue with the apiserver fake.
We should find a way to adequately test this wiring which doesn't leave us with tightly coupled test-doubles like this. This might involve leaning more heavily on the integration tests for the happy path, and removing the unit-level happy path tests.
This issue began as a conversation with @apelisse in #149
The text was updated successfully, but these errors were encountered:
In the test framework MVP (discussed in #87 ), there is currently a tight coupling between the test fakes
pkg/frameworks/test/assets/fakeetcd/
andetcd.go
. In particular, both of these currently know the exact flags thatetcd
ought to be called with. There is a similar issue with the apiserver fake.We should find a way to adequately test this wiring which doesn't leave us with tightly coupled test-doubles like this. This might involve leaning more heavily on the integration tests for the happy path, and removing the unit-level happy path tests.
This issue began as a conversation with @apelisse in #149
The text was updated successfully, but these errors were encountered: