Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Test Framework's test fakes shouldn't be so tightly coupled with the implementations they test #153

Closed
totherme opened this issue Nov 30, 2017 · 3 comments
Assignees

Comments

@totherme
Copy link
Contributor

totherme commented Nov 30, 2017

In the test framework MVP (discussed in #87 ), there is currently a tight coupling between the test fakes pkg/frameworks/test/assets/fakeetcd/ and etcd.go. In particular, both of these currently know the exact flags that etcd ought to be called with. There is a similar issue with the apiserver fake.

We should find a way to adequately test this wiring which doesn't leave us with tightly coupled test-doubles like this. This might involve leaning more heavily on the integration tests for the happy path, and removing the unit-level happy path tests.

This issue began as a conversation with @apelisse in #149

@totherme
Copy link
Contributor Author

After investigating, we think that fixing this issue will make #152 easier, so we'd like to start with this.

@hoegaarden and I would like to work on this please.

cc @seans3 @mengqiy I would like to take this

@hoegaarden
Copy link
Contributor

As #154 & #155 are merged, this issue can be closed.
@totherme @apelisse

@apelisse apelisse closed this as completed Dec 5, 2017
@apelisse
Copy link
Member

apelisse commented Dec 5, 2017

I think you can use /close or something :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants