Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Promote SSA GA #100139

Merged
merged 1 commit into from
Apr 25, 2021
Merged

Promote SSA GA #100139

merged 1 commit into from
Apr 25, 2021

Conversation

Jefftree
Copy link
Member

@Jefftree Jefftree commented Mar 11, 2021 •
edited

What type of PR is this?

/kind feature

What this PR does / why we need it:

Promote SSA to GA. The original PR was reverted per #99652 (comment)

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Blocked on one last PR: #100496

Does this PR introduce a user-facing change?

SSA is GA

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

/triage accepted

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/apiserver sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 11, 2021
@Jefftree
Copy link
Member Author

/retest

@Jefftree
Copy link
Member Author

/close

deferring to 1.22

@Jefftree Jefftree closed this Mar 13, 2021
@Jefftree Jefftree reopened this Apr 6, 2021
@Jefftree
Copy link
Member Author

/cc @apelisse @jpbetz
/assign @lavalamp

Last PR that needs still needs to be merged: #100496

@lavalamp
Copy link
Member

/lgtm
/approve
/hold

Unhold once Joe's PR merges :)

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Apr 23, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jefftree, lavalamp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 23, 2021
@apelisse
Copy link
Member

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 25, 2021
@k8s-ci-robot k8s-ci-robot merged commit 6067d85 into kubernetes:master Apr 25, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Apr 25, 2021
@lavalamp
Copy link
Member

🥳🥳🥳🥳🥳🥳🥳🥳🥳

@github-actions github-actions bot mentioned this pull request Apr 27, 2021
Open
@Jefftree Jefftree deleted the ssa-ga2 branch December 7, 2021 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@hzxuzhonghu hzxuzhonghu Awaiting requested review from hzxuzhonghu

@apelisse apelisse Awaiting requested review from apelisse

@jpbetz jpbetz Awaiting requested review from jpbetz

Assignees

@lavalamp lavalamp

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.22
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Jefftree @lavalamp @k8s-ci-robot @apelisse