Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

namespace update fails in AdmissionWebhook e2e tests #100197

Closed
chaitanyabandi opened this issue Mar 12, 2021 · 2 comments · Fixed by #100199
Closed

namespace update fails in AdmissionWebhook e2e tests #100197

chaitanyabandi opened this issue Mar 12, 2021 · 2 comments · Fixed by #100199
Labels
sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@chaitanyabandi
Copy link
Contributor

In VMware Tanzu Supervisor Cluster k8s setup, we observed that the AdmissionWebhook tests fail intermittently while updating the namespace with the error: "the object has been modified; please apply your changes to the latest version and try again". This is because the update conflicts with an update being performed by another controller.

The test could use Patch while adding labels via types.StrategicMergePatchType to prevent the conflict.

kubernetes/test/e2e/apimachinery/webhook.go

Line 2136 in 9d59046

_, err = client.CoreV1().Namespaces().Update(context.TODO(), ns, metav1.UpdateOptions{})

/sig testing
/sig api-machinery
@k8s-ci-robot k8s-ci-robot added sig/testing Categorizes an issue or PR as relevant to SIG Testing. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 12, 2021
@chaitanyabandi chaitanyabandi mentioned this issue Mar 12, 2021
Merged
@BenTheElder BenTheElder removed the sig/testing Categorizes an issue or PR as relevant to SIG Testing. label Mar 15, 2021
@BenTheElder
Copy link
Member

(sig testing owns e.g. the frameworks but API Machinery own their test cases)

@chaitanyabandi chaitanyabandi mentioned this issue Mar 15, 2021
Merged
@fedebongio
Copy link
Contributor

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

use Patch API to add namespace label chaitanyabandi/kubernetes
4 participants
@BenTheElder @fedebongio @chaitanyabandi @k8s-ci-robot