Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initialise capabilities unit test #100203

Merged
merged 1 commit into from Mar 13, 2021
Merged

Conversation

aojea
Copy link
Member

@aojea aojea commented Mar 13, 2021

/kind failing-test
/kind flake

NONE

The test needs to initialise the variable, or subsequent testrun carry over the previous state.
Before:

=== FAIL: pkg/capabilities TestGet (0.00s)
    capabilities_test.go:36: expected Capabilities: capabilities.Capabilities{AllowPrivileged:false, PrivilegedSources:capabilities.PrivilegedSources{HostNetworkSources:[]string{}, HostPIDSources:[]string{}, HostIPCSources:[]string{}}, PerConnectionBandwidthLimitBytesPerSec:0}, got a non-default: capabilities.Capabilities{AllowPrivileged:false, PrivilegedSources:capabilities.PrivilegedSources{HostNetworkSources:[]string{"A", "B"}, HostPIDSources:[]string(nil), HostIPCSources:[]string(nil)}, PerConnectionBandwidthLimitBytesPerSec:0}
    capabilities_test.go:36: expected Capabilities: capabilities.Capabilities{AllowPrivileged:false, PrivilegedSources:capabilities.PrivilegedSources{HostNetworkSources:[]string{}, HostPIDSources:[]string{}, HostIPCSources:[]string{}}, PerConnectionBandwidthLimitBytesPerSec:0}, got a non-default: capabilities.Capabilities{AllowPrivileged:false, PrivilegedSources:capabilities.PrivilegedSources{HostNetworkSources:[]string{"A", "B"}, HostPIDSources:[]string(nil), HostIPCSources:[]string(nil)}, PerConnectionBandwidthLimitBytesPerSec:0}

With current change:

[aojea@aojea-laptop kubernetes]$ go test -timeout 300s -count 300  ./pkg/capabilities/ -run .
ok      k8s.io/kubernetes/pkg/capabilities      0.004s

xref: https://testgrid.k8s.io/sig-testing-canaries#ci-kubernetes-generate-make-test-count10

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. kind/flake Categorizes issue or PR as related to a flaky test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 13, 2021
@k8s-ci-robot
Copy link
Contributor

@aojea: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Mar 13, 2021
@aojea
Copy link
Member Author

aojea commented Mar 13, 2021

/assign @liggitt @spiffxp

@aojea
Copy link
Member Author

aojea commented Mar 13, 2021

/sig testing

@k8s-ci-robot k8s-ci-robot added sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 13, 2021
@liggitt
Copy link
Member

liggitt commented Mar 13, 2021

/lgtm
/approve

/milestone v1.21

test-only change to fix a failing test in the flake flushing job

@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Mar 13, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 13, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 13, 2021
@k8s-ci-robot k8s-ci-robot merged commit 980b79c into kubernetes:master Mar 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. kind/flake Categorizes issue or PR as related to a flaky test. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants