Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark v2beta1 and v2beta2 HPA status conditions as optional #100318

Merged
merged 1 commit into from
Oct 29, 2021
Merged

Mark v2beta1 and v2beta2 HPA status conditions as optional #100318

merged 1 commit into from
Oct 29, 2021

Conversation

zeleena
Copy link
Contributor

@zeleena zeleena commented Mar 16, 2021

What type of PR is this?

/kind bug

What this PR does / why we need it:

Marks v2beta2 HPA status conditions field as optional. conditions is a subfield of status which is already optional. This was found when serializing a valid HPA with no status field - this resulted in an unnecessary client-side apply ValidationError, stating that it was missing the required field conditions. This error should be fixed since it is a subfield of status which is not required.

Which issue(s) this PR fixes:

Fixes #100021

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 16, 2021
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 16, 2021
@k8s-ci-robot
Copy link
Contributor

@zeleena: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

Welcome @zeleena!

It looks like this is your first PR to kubernetes/kubernetes 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kubernetes has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 16, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @zeleena. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-priority Indicates a PR lacks a `priority/foo` label and requires one. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API labels Mar 16, 2021
@fejta-bot
Copy link

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@zeleena
Copy link
Contributor Author

zeleena commented May 19, 2021

/retest

@k8s-ci-robot
Copy link
Contributor

@zeleena: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@zeleena
Copy link
Contributor Author

zeleena commented May 19, 2021

I signed it

1 similar comment
@zeleena
Copy link
Contributor Author

zeleena commented May 19, 2021

I signed it

@zeleena zeleena closed this May 19, 2021
@zeleena zeleena reopened this May 19, 2021
@zeleena
Copy link
Contributor Author

zeleena commented May 19, 2021

I signed it

@zeleena zeleena closed this May 19, 2021
@zeleena zeleena reopened this May 19, 2021
@zeleena
Copy link
Contributor Author

zeleena commented May 19, 2021

/check-cla

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels May 19, 2021
@zeleena
Copy link
Contributor Author

zeleena commented May 20, 2021

/retest

@k8s-ci-robot
Copy link
Contributor

@zeleena: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Oct 28, 2021
@fedebongio
Copy link
Contributor

/remove-sig api-machinery

@k8s-ci-robot k8s-ci-robot removed the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Oct 28, 2021
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Oct 28, 2021
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Oct 28, 2021 •
edited

@zeleena: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-e2e-gce-storage-slow f5b33bb061f82c48a78b8024caee51d8b352c9c0 link false /test pull-kubernetes-e2e-gce-storage-slow
pull-kubernetes-e2e-gce-storage-snapshot f5b33bb061f82c48a78b8024caee51d8b352c9c0 link false /test pull-kubernetes-e2e-gce-storage-snapshot
pull-kubernetes-e2e-gci-gce-ipvs f5b33bb061f82c48a78b8024caee51d8b352c9c0 link false /test pull-kubernetes-e2e-gci-gce-ipvs
pull-kubernetes-e2e-aks-engine-azure-disk-windows-dockershim f5b33bb061f82c48a78b8024caee51d8b352c9c0 link false /test pull-kubernetes-e2e-aks-engine-azure-disk-windows-dockershim
pull-kubernetes-e2e-capz-azure-disk f5b33bb061f82c48a78b8024caee51d8b352c9c0 link false /test pull-kubernetes-e2e-capz-azure-disk
pull-kubernetes-e2e-capz-azure-file-vmss f5b33bb061f82c48a78b8024caee51d8b352c9c0 link false /test pull-kubernetes-e2e-capz-azure-file-vmss
pull-kubernetes-e2e-gce-csi-serial f5b33bb061f82c48a78b8024caee51d8b352c9c0 link false /test pull-kubernetes-e2e-gce-csi-serial
pull-kubernetes-e2e-capz-conformance f5b33bb061f82c48a78b8024caee51d8b352c9c0 link false /test pull-kubernetes-e2e-capz-conformance
pull-kubernetes-e2e-gci-gce-ingress f5b33bb061f82c48a78b8024caee51d8b352c9c0 link false /test pull-kubernetes-e2e-gci-gce-ingress
pull-kubernetes-e2e-ubuntu-gce-network-policies f5b33bb061f82c48a78b8024caee51d8b352c9c0 link false /test pull-kubernetes-e2e-ubuntu-gce-network-policies
pull-kubernetes-conformance-kind-ipv6-parallel f5b33bb061f82c48a78b8024caee51d8b352c9c0 link false /test pull-kubernetes-conformance-kind-ipv6-parallel
pull-kubernetes-e2e-aks-engine-windows-containerd f5b33bb061f82c48a78b8024caee51d8b352c9c0 link false /test pull-kubernetes-e2e-aks-engine-windows-containerd
pull-kubernetes-e2e-capz-azure-file f5b33bb061f82c48a78b8024caee51d8b352c9c0 link false /test pull-kubernetes-e2e-capz-azure-file
pull-kubernetes-e2e-aks-engine-azure-file-windows-dockershim f5b33bb061f82c48a78b8024caee51d8b352c9c0 link false /test pull-kubernetes-e2e-aks-engine-azure-file-windows-dockershim
pull-kubernetes-e2e-capz-azure-disk-vmss f5b33bb061f82c48a78b8024caee51d8b352c9c0 link false /test pull-kubernetes-e2e-capz-azure-disk-vmss

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zeleena zeleena changed the title Mark v2beta2 HPA status conditions as optional Mark v2beta1 and v2beta2 HPA status conditions as optional Oct 28, 2021
@zeleena
Copy link
Contributor Author

zeleena commented Oct 28, 2021

Comments addressed, PR rebased, and commits squashed. Please let me know if there's anything else I should do.

@liggitt
Copy link
Member

liggitt commented Oct 29, 2021

/lgtm
/approve

@liggitt liggitt moved this from Changes requested to API review completed, 1.23 in API Reviews Oct 29, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 29, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, zeleena

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 29, 2021
@k8s-ci-robot k8s-ci-robot merged commit a8cf023 into kubernetes:master Oct 29, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Oct 29, 2021
@zeleena zeleena deleted the hpa-v2beta2-opt-conditions branch October 29, 2021 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alculquicondor alculquicondor alculquicondor left review comments

@josephburnett josephburnett josephburnett requested changes

@caesarxuchao caesarxuchao Awaiting requested review from caesarxuchao

@piosz piosz Awaiting requested review from piosz

Assignees

@liggitt liggitt

@josephburnett josephburnett

@alculquicondor alculquicondor

Labels
api-review Categorizes an issue or PR as actively needing an API review. approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/cloudprovider area/code-generation area/ipvs area/kubeadm area/kubectl area/kubelet area/release-eng Issues or PRs related to the Release Engineering subproject area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/autoscaling Categorizes an issue or PR as relevant to SIG Autoscaling. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
API Reviews
Status: API review completed, 1.23
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.

NewSerializerWithOptions yaml for v2beta2 HPA cannot be applied with ValidationError
7 participants
@zeleena @k8s-ci-robot @fejta-bot @josephburnett @liggitt @fedebongio @alculquicondor