Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a panic in "e2e.test --help" #100362

Merged
merged 1 commit into from Mar 23, 2021
Merged

Fix a panic in "e2e.test --help" #100362

merged 1 commit into from Mar 23, 2021

Conversation

CaoDonghui123
Copy link
Contributor

@CaoDonghui123 CaoDonghui123 commented Mar 18, 2021 •
edited

What type of PR is this?

/kind bug

What this PR does / why we need it:

Fix a panic in "e2e.test --help"

Which issue(s) this PR fixes:

Fixes #100342

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. kind/bug Categorizes issue or PR as related to a bug. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Mar 18, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @CaoDonghui123. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 18, 2021
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Mar 18, 2021
neolit123
neolit123 reviewed Mar 18, 2021
View reviewed changes
staging/src/k8s.io/component-base/cli/flag/string_slice_flag.go
@@ -38,12 +38,16 @@ var _ goflag.Value = &StringSlice{}
var _ pflag.Value = &StringSlice{}

func (s *StringSlice) String() string {
if s == nil || s.value == nil {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why does this happen?

i saw the linked PR:
https://github.com/kubernetes/kubernetes/pull/98787/files

and it has https://github.com/kubernetes/kubernetes/pull/98787/files#diff-c017e0c5e68c14cb966137bc87de3d3ab8475dc25f9b5fdb47a2b8174830054fR343

flags.Var(cliflag.NewStringSlice(&cloudConfig.Zones), "gce-zones", "The set of zones to use in a multi-zone test instead of querying the cloud provider.")

isn't that sufficient for --help not to panic?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, looks like this change is valid, given we want to append to the cloudConfig.Zones slice.

@caesarxuchao
Copy link
Member

/assign @DangerOnTheRanger
/triage accepted

@k8s-ci-robot
Copy link
Contributor

@caesarxuchao: GitHub didn't allow me to assign the following users: DangerOnTheRanger.

Note that only kubernetes members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @DangerOnTheRanger
/triage accepted

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 18, 2021
@BenTheElder
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 19, 2021
@CaoDonghui123
Copy link
Contributor Author

/test pull-kubernetes-e2e-gce-ubuntu-containerd

@BenTheElder
Copy link
Member

/assign lavalamp mtaufen

@DangerOnTheRanger
Copy link
Contributor

LGTM!

@lavalamp
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 23, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CaoDonghui123, lavalamp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 23, 2021
@justaugustus
Copy link
Member

/milestone v1.21
ref Slack discussion: https://kubernetes.slack.com/archives/CJH2GBF7Y/p1616530260091100

@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Mar 23, 2021
@k8s-ci-robot k8s-ci-robot merged commit e471fa4 into kubernetes:master Mar 23, 2021
@CaoDonghui123 CaoDonghui123 mentioned this pull request May 6, 2021
Closed
6 tasks
@vazmin vazmin mentioned this pull request Jun 16, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neolit123 neolit123 neolit123 left review comments

@rosti rosti Awaiting requested review from rosti

@sttts sttts Awaiting requested review from sttts

Assignees

@lavalamp lavalamp

@mtaufen mtaufen

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.

"e2e.test --help" panics due to bad flag-parsing code
9 participants
@CaoDonghui123 @k8s-ci-robot @caesarxuchao @BenTheElder @DangerOnTheRanger @lavalamp @justaugustus @neolit123 @mtaufen