Remove suffixes for VolumeSnapshotClasses in E2E tests #100484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
area/test
sig/storage
|
/test pull-kubernetes-e2e-gce-storage-slow |
oomichi
reviewed
Mar 23, 2021
| ) *unstructured.Unstructured { | ||
| snapshotClass := &unstructured.Unstructured{ | ||
| Object: map[string]interface{}{ | ||
| "kind": "VolumeSnapshotClass", | ||
| "apiVersion": SnapshotAPIVersion, | ||
| "metadata": map[string]interface{}{ | ||
| // Name must be unique, so let's base it on namespace name and use GenerateName | ||
| // TODO(#96234): Remove unnecessary suffix. | ||
| "name": names.SimpleNameGenerator.GenerateName(ns + "-" + suffix), | ||
| "name": names.SimpleNameGenerator.GenerateName(ns), |
There was a problem hiding this comment.
/lgtm
because of
49 func (simpleNameGenerator) GenerateName(base string) string {
50 if len(base) > maxGeneratedNameLength {
51 base = base[:maxGeneratedNameLength]
52 }
53 return fmt.Sprintf("%s%s", base, utilrand.String(randomLength))
54 }
|
/retest |
|
/assign @gnufied |
|
/triage accepted |
k8s-ci-robot
added
triage/accepted
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gavinfish, oomichi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/test pull-kubernetes-e2e-kind |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Suffixes for generated VolumeSnapshotClass objects can be removed since they already have randomly generated names.
Which issue(s) this PR fixes:
Xref #96234
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: