Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #100254: apf: handle error from PollImmediateUntil #100524

Merged
merged 1 commit into from Mar 29, 2021
Merged

Automated cherry pick of #100254: apf: handle error from PollImmediateUntil #100524

merged 1 commit into from Mar 29, 2021

Conversation

tkashem
Copy link
Contributor

@tkashem tkashem commented Mar 24, 2021 •
edited

Cherry pick of #100254 on release-1.20.

#100254: apf: handle error from PollImmediateUntil

This bug is unlikely to occur but when it does the severity can be high, for more details see the explanation in the original PR: #100254 (comment)

@tkashem
apf: handle error from PollImmediateUntil
1e316e6 
We should not attempt creation of mandatory objects if ensuring
the suggested configuration resulted in an error.
We rely on the presence of the "exempt" priority level configuration
object in the cluster to indicate whether we should ensure
suggested configuration.
@k8s-ci-robot k8s-ci-robot added the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Mar 24, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Mar 24, 2021
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 24, 2021
@tkashem
Copy link
Contributor Author

tkashem commented Mar 24, 2021

/kind bug
/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Mar 24, 2021
@tkashem
Copy link
Contributor Author

tkashem commented Mar 24, 2021

/test pull-kubernetes-e2e-kind

@tkashem
Copy link
Contributor Author

tkashem commented Mar 24, 2021

/assign @MikeSpreitzer @lavalamp

@lavalamp
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 24, 2021
@tkashem
Copy link
Contributor Author

tkashem commented Mar 24, 2021

/test pull-kubernetes-e2e-kind

1 similar comment
@tkashem
Copy link
Contributor Author

tkashem commented Mar 25, 2021

/test pull-kubernetes-e2e-kind

hasheddan
hasheddan approved these changes Mar 29, 2021
View reviewed changes
Copy link
Contributor

@hasheddan hasheddan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/sig api-machinery

@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 29, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hasheddan, lavalamp, MikeSpreitzer, tkashem

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hasheddan hasheddan added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Mar 29, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Mar 29, 2021
@k8s-ci-robot k8s-ci-robot merged commit c7c94ea into kubernetes:release-1.20 Mar 29, 2021
@fedebongio
Copy link
Contributor

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MikeSpreitzer MikeSpreitzer MikeSpreitzer approved these changes

@hasheddan hasheddan hasheddan approved these changes

@deads2k deads2k Awaiting requested review from deads2k

@dims dims Awaiting requested review from dims

Assignees

@lavalamp lavalamp

@MikeSpreitzer MikeSpreitzer

@hasheddan hasheddan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.20
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@tkashem @lavalamp @k8s-ci-robot @fedebongio @MikeSpreitzer @hasheddan