Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #98571: Stop probing a pod during graceful shutdown #100527

Merged
merged 1 commit into from Apr 9, 2021
Merged

Automated cherry pick of #98571: Stop probing a pod during graceful shutdown #100527

merged 1 commit into from Apr 9, 2021

Conversation

matthyx
Copy link
Contributor

@matthyx matthyx commented Mar 24, 2021

Cherry pick of #98571 on release-1.18.

#98571: Stop probing a pod during graceful shutdown

For details on the cherry pick process, see the cherry pick requests page.

@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Mar 24, 2021
@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 24, 2021
@k8s-ci-robot k8s-ci-robot added area/kubelet sig/node Categorizes an issue or PR as relevant to SIG Node. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 24, 2021
@matthyx matthyx mentioned this pull request Mar 24, 2021
Closed
@matthyx
Copy link
Contributor Author

matthyx commented Mar 24, 2021

/release-note-none
/kind bug
/priority important-soon
/triage accepted

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 24, 2021
@ehashman ehashman added this to Triage in SIG Node PR Triage Mar 27, 2021
@ehashman ehashman moved this from Triage to Needs Reviewer in SIG Node PR Triage Mar 27, 2021
@hermanbanken
Copy link

hermanbanken commented Apr 2, 2021 •
edited

Yes please! This is especially relevant now that Google Errors is reporting Kubernetes events:

Screenshot 2021-04-02 at 12 04 11

Source of these "new" errors being reported is the release of "Service Errors" on March 31st [1] [2].

[1] = https://cloud.google.com/stackdriver/docs/release-notes#March_31_2021
[2] = https://cloud.google.com/error-reporting/docs/service-errors

@SergeyKanzhelev
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 8, 2021
@ehashman ehashman moved this from Needs Reviewer to Needs Approver in SIG Node PR Triage Apr 8, 2021
@dchen1107
Copy link
Member

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dchen1107, matthyx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 8, 2021
@ehashman ehashman moved this from Needs Approver to Done in SIG Node PR Triage Apr 9, 2021
@feiskyer feiskyer added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Apr 9, 2021
@k8s-ci-robot k8s-ci-robot merged commit c7c1ad4 into kubernetes:release-1.18 Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattjmcnaughton mattjmcnaughton Awaiting requested review from mattjmcnaughton

@vishh vishh Awaiting requested review from vishh

Assignees

@dchen1107 dchen1107

@SergeyKanzhelev SergeyKanzhelev

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node PR Triage
Done
Milestone
v1.18
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@matthyx @hermanbanken @SergeyKanzhelev @dchen1107 @k8s-ci-robot @feiskyer