staging/publishing: add branch-specific smoke tests #100554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `-mod=mod` option is only supported from go1.14. Since `release-1.18` and `release-1.17` branches use go1.13.15, this commit adds smoke tests per branch to only add the `-mod=mod` option to branches after `release-1.18`. The duplicate smoke test config can be removed once v1.21 is released and v1.18 is out of support.
k8s-ci-robot
added
do-not-merge/hold
|
/triage accepted |
k8s-ci-robot
added
triage/accepted
k8s-ci-robot
added
the
approved
|
cc @palnabarun - this will need to be in the v1.21 milestone |
|
/assign @sttts |
|
/milestone v1.21 /retest |
|
/lgtm until https://github.com/kubernetes/publishing-bot/pull/251/files merged |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, nikhita The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
The
-mod=modoption is only supported from go1.14. Sincerelease-1.18and
release-1.17branches use go1.13.15, this commit adds smoke testsper branch to only add the
-mod=modoption to branches afterrelease-1.18.The duplicate smoke test config can be removed once v1.21 is released
and v1.18 is out of support.
See more details in kubernetes/publishing-bot#251.
/hold
This should not merge before kubernetes/publishing-bot#251 has been merged and deployed
Which issue(s) this PR fixes:
#56876 (comment)
Does this PR introduce a user-facing change?