Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test images: Adds cuda-vector-add-old image #100887

Merged
merged 1 commit into from Jul 13, 2021
Merged

test images: Adds cuda-vector-add-old image #100887

merged 1 commit into from Jul 13, 2021

Conversation

claudiubelu
Copy link
Contributor

@claudiubelu claudiubelu commented Apr 7, 2021 •
edited

What type of PR is this?

/kind cleanup
/sig testing

What this PR does / why we need it:

Currently, the only image left in gcr.io/kubernetes-e2e-test-images is the cuda-vector-add:1.0 image.

According to 8408188cdf4b8d3a6063015ea5a52de9b2a90821, the 1.0 image was based on CUDA 8.0, while the 2.0 version is based on CUDA 10.0. We can simply rebuild the 1.0 image based on the CUDA 8.0 image and then promote the new image.

Added ALIAS file, which specifies what the image name should be, similarly to how we build multiple versions of nginx and httpd.

Note that the image CMD was changed from ./vectorAdd to nvidia-smi && ./vectorAdd in 2.0.

Which issue(s) this PR fixes:

Related: #96770
Related: #100886
Depends On: kubernetes/test-infra#21695

Special notes for your reviewer:

Image building logs: https://paste.ubuntu.com/p/qyx7csww7h/

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@claudiubelu
test images: Adds cuda-vector-add-old image
b42c1a3 
Currently, the only image left in gcr.io/kubernetes-e2e-test-images is the
cuda-vector-add:1.0 image.

According to 8408188, the 1.0 image was based on CUDA 8.0,
while the 2.0 version is based on CUDA 10.0. We can simply rebuild the 1.0 image based on
the CUDA 8.0 image and then promote the new image.

Added ALIAS file, which specifies what the image name should be, similarly to how we build
multiple versions of nginx and httpd.

Note that the image CMD was changed from "./vectorAdd" to "nvidia-smi && ./vectorAdd" in 2.0.
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. sig/testing Categorizes an issue or PR as relevant to SIG Testing. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 7, 2021
@k8s-ci-robot
Copy link
Contributor

@claudiubelu: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Apr 7, 2021
@claudiubelu claudiubelu mentioned this pull request Apr 7, 2021
Merged
@claudiubelu
Copy link
Contributor Author

/cc @spiffxp

@claudiubelu
Copy link
Contributor Author

/retest

@claudiubelu
Copy link
Contributor Author

/cc @mkumatag

@claudiubelu
Copy link
Contributor Author

/retest

@justaugustus
Copy link
Member

/lgtm
/hold for other reviews

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 13, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 13, 2021
@spiffxp
Copy link
Member

spiffxp commented May 26, 2021

/cc
to review after k8s-infra meeting

@pacoxu
Copy link
Member

pacoxu commented Jul 13, 2021

milestone 1.22 as #96770 ?

@pacoxu pacoxu mentioned this pull request Jul 13, 2021
Merged
spiffxp
spiffxp approved these changes Jul 13, 2021
View reviewed changes
Copy link
Member

@spiffxp spiffxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm
/milestone v1.22
As sig-testing chair

@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Jul 13, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: claudiubelu, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 13, 2021
@spiffxp
Copy link
Member

spiffxp commented Jul 13, 2021

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 13, 2021
@claudiubelu
Copy link
Contributor Author

/test pull-kubernetes-e2e-gce-ubuntu-containerd

@k8s-ci-robot k8s-ci-robot merged commit dbfa5ac into kubernetes:master Jul 13, 2021
@pacoxu pacoxu mentioned this pull request Jul 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spiffxp spiffxp spiffxp approved these changes

@dims dims Awaiting requested review from dims

@justaugustus justaugustus Awaiting requested review from justaugustus

@mkumatag mkumatag Awaiting requested review from mkumatag

Assignees

@spiffxp spiffxp

@justaugustus justaugustus

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.22
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@claudiubelu @k8s-ci-robot @justaugustus @spiffxp @pacoxu