Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set namespace when using kubectl create service #101005

Merged
merged 2 commits into from Apr 29, 2021
Merged

Set namespace when using kubectl create service #101005

merged 2 commits into from Apr 29, 2021

Conversation

zxh326
Copy link
Contributor

@zxh326 zxh326 commented Apr 12, 2021 •
edited

What type of PR is this?

/kind bug

What this PR does / why we need it:

  • Set namespace when create service
  • Add EnforceNamespace for ServiceOptions

Which issue(s) this PR fixes:

Fixes #100995

Special notes for your reviewer:

Does this PR introduce a user-facing change?

kubectl create service now respects namespace flag

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Apr 12, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @zxh326. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. area/kubectl sig/cli Categorizes an issue or PR as relevant to SIG CLI. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 12, 2021
@k8s-ci-robot
Copy link
Contributor

@zxh326: GitHub didn't allow me to assign the following users: PTAL.

Note that only kubernetes members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @brendandburns PTAL

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rikatz
Copy link
Contributor

rikatz commented Apr 12, 2021

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 12, 2021
@rikatz
Copy link
Contributor

rikatz commented Apr 12, 2021

/triage accepted
/priority important-longterm

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Apr 12, 2021
rikatz
rikatz approved these changes Apr 19, 2021
View reviewed changes
Copy link
Contributor

@rikatz rikatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thank you!!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 19, 2021
@rikatz
Copy link
Contributor

rikatz commented Apr 19, 2021

/assign @eddiezane @soltysh @brianpursley

eddiezane
eddiezane suggested changes Apr 22, 2021
View reviewed changes
Copy link
Member

@eddiezane eddiezane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add a test for this please to catch regression.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 22, 2021
@zxh326 zxh326 requested review from eddiezane and rikatz April 22, 2021 09:42
@zxh326
Copy link
Contributor Author

zxh326 commented Apr 22, 2021

/retest

rikatz
rikatz approved these changes Apr 28, 2021
View reviewed changes
Copy link
Contributor

@rikatz rikatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Now with tests :)

Thanks!!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 28, 2021
@eddiezane
Copy link
Member

Thanks!

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 29, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eddiezane, rikatz, zxh326

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eddiezane
Copy link
Member

@zxh326 can you please add a release note for this?

Something like kubectl create service now respects namespace flag.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Apr 29, 2021
@zxh326
Copy link
Contributor Author

zxh326 commented Apr 29, 2021

@zxh326 can you please add a release note for this?

Something like kubectl create service now respects namespace flag.

Added

@eddiezane
Copy link
Member

I'm going to cherry pick this to 1.21 since 1.22 won't be out until August.

@k8s-ci-robot k8s-ci-robot merged commit 02c556d into kubernetes:master Apr 29, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Apr 29, 2021
@zxh326 zxh326 mentioned this pull request Apr 29, 2021
Merged
@eddiezane eddiezane mentioned this pull request May 6, 2021
Merged
k8s-ci-robot added a commit that referenced this pull request May 7, 2021
@k8s-ci-robot
Merge pull request #101620 from zxh326/automated-cherry-pick-of-#1010…
714657f 
…05-upstream-release-1.21

Automated cherry pick of #101005: Set namespace when using kubectl create service
k8s-ci-robot added a commit that referenced this pull request May 7, 2021
@k8s-ci-robot
Merge pull request #101769 from eddiezane/automated-cherry-pick-of-#1…
c28b41d 
…01005-upstream-release-1.20

Automated cherry pick of #101005: Set namespace when using kubectl create service
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eddiezane eddiezane eddiezane approved these changes

@rikatz rikatz rikatz approved these changes

@dixudx dixudx Awaiting requested review from dixudx

Assignees

@soltysh soltysh

@eddiezane eddiezane

@brianpursley brianpursley

@brendandburns brendandburns

@rikatz rikatz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubectl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cli Categorizes an issue or PR as relevant to SIG CLI. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.22
Development

Successfully merging this pull request may close these issues.

Namespace is not set when using kubectl to generate service
7 participants
@zxh326 @k8s-ci-robot @rikatz @eddiezane @soltysh @brianpursley @brendandburns