Upgrade kustomize-in-kubectl to v4.1.2

[monopole]

What type of PR is this?

/kind bug
/sig cli
/priority important-soon

What this PR does / why we need it:

This upgrades kustomize to depend on kustomize v4.1.2.
It mitigates a concern that a user might download and use a
maliciously crafted remote configuration.

Special notes for your reviewer:

This is a go.mod change to upgrade the kustomize
dependency from v4.0.5 to v4.1.2.

Does this PR introduce a user-facing change?

Yes with respect to kubectl v1.21, no with respect to earlier versions
of kubectl. kustomize was last upgraded on 8 March 2021 (#98946).

If a user has a kustomization.yaml file with values defined for the
helmChartInflationGenerator field, and the user runs

kubectl kustomize {target}

the user will be asked to also specify the --enable-helm flag to
allow processing to continue. Previously the --enable-helm flag
did not exist. This is to increase awareness that helm template...
will be run as a subprocess to inflate a template.

Further, the helmBin subfield of helmChartInflationGenerator field
will be ignored. If the helm command is anything other than simply
helm (on the user's PATH), then the user must specify it via the
--helm-command flag.

The helmChartInflationGenerator was not read at all in kubectl
versions preceding v1.21.

Upgrades functionality of `kubectl kustomize` as described at
https://github.com/kubernetes-sigs/kustomize/releases/tag/kustomize%2Fv4.1.2

How was this PR made?

./hack/pin-dependency.sh sigs.k8s.io/kustomize/kyaml v0.10.17
./hack/pin-dependency.sh sigs.k8s.io/kustomize/cmd/config v0.9.10
./hack/pin-dependency.sh sigs.k8s.io/kustomize/api v0.8.8
./hack/pin-dependency.sh sigs.k8s.io/kustomize/kustomize/v4 v4.1.2

./hack/update-vendor.sh
./hack/update-internal-modules.sh 
./hack/lint-dependencies.sh 

rm ./_output/local/bin/linux/amd64/kubectl
make kubectl
./_output/local/bin/linux/amd64/kubectl help kustomize | grep enable-helm
      --enable-helm=false: Enable use of the Helm chart inflator generator.

[monopole]

/test pull-kubernetes-unit

[KnVerey]

/test pull-kubernetes-e2e-kind-ipv6
/test pull-kubernetes-integration

[KnVerey]

/triage accepted
/lgtm

[liggitt]

this change looks buggy... opened darccio/mergo#187

[monopole]

Rolled back to mergo v0.3.5, so no change in k8s mergo deps for now.

[liggitt]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, monopole

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [liggitt]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[monopole]

/test pull-kubernetes-e2e-kind-ipv6

[pickfire]

Isn't this breaking changes such that --enable-helm is required now but previously it wasn't require? Shouldn't it require a new version to do these sort of breaking changes? Also, the error message was very confusing.

Error: accumulating resources: accumulation err='accumulating resources from '../../base': '/mnt/overlays/dev/base' must resolve to a file': recursed accumulation of path '/mnt/overlays/dev/base': accumulating resources: accumulation err='accumulating resources from '../../../resources/nats': '/mnt/resources/nats' must resolve to a file': recursed accumulation of path '/mnt/resources/nats': trouble configuring builtin HelmChartInflationGenerator with config: `
name: stan
releaseName: semut-stan
repo: https://nats-io.github.io/k8s/helm/charts/
valuesFile: values.yaml
version: 0.8.0
`: must specify --enable-helm

Also, apply was broken in 1.21.1, it cannot specify --enable-helm but it requires --enable-helm?