Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Agnhost image's progress name is called agnhost, not test-webserver #101191

Merged
merged 1 commit into from
Apr 22, 2021
Merged

Agnhost image's progress name is called agnhost, not test-webserver #101191

merged 1 commit into from
Apr 22, 2021

Conversation

tanjing2020
Copy link
Contributor

@tanjing2020 tanjing2020 commented Apr 16, 2021 •
edited

What type of PR is this?

/kind bug

What this PR does / why we need it:

The process name is called agnhost not test-webserver after the Agnhost image is started.

image

wsPids, err = getPidsForProcess("test-webserver", "")
for _, pid := range wsPids {
    if err := validateOOMScoreAdjSettingIsInRange(pid, 2, 1000); err != nil {
        return err
    }
}

The value obtained by wsPids is 0, so the detection of oom_score_adj is not performed.
Then the error in #100519 has not been found.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/test sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 16, 2021
@claudiubelu
Copy link
Contributor

/lgtm

Makes sense.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 16, 2021
@odinuge
Copy link
Member

odinuge commented Apr 16, 2021

Thanks!

/triage accepted
/priority important-longterm
/retest

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Apr 16, 2021
@tanjing2020
Copy link
Contributor Author

/retest

1 similar comment
@tanjing2020
Copy link
Contributor Author

/retest

@ehashman ehashman added this to Needs Approver in SIG Node PR Triage Apr 16, 2021
@ehashman ehashman added this to PRs - Needs Approver in SIG Node CI/Test Board Apr 16, 2021
@mrunalp
Copy link
Contributor

mrunalp commented Apr 22, 2021

/approve

@mrunalp mrunalp moved this from Needs Approver to Done in SIG Node PR Triage Apr 22, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mrunalp, tanjing2020

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 22, 2021
@k8s-ci-robot k8s-ci-robot merged commit 1b08dde into kubernetes:master Apr 22, 2021
SIG Node CI/Test Board automation moved this from PRs - Needs Approver to Done Apr 22, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Apr 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MHBauer MHBauer Awaiting requested review from MHBauer

@odinuge odinuge Awaiting requested review from odinuge

Assignees

@claudiubelu claudiubelu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node CI/Test Board
Done
SIG Node CI/Test Board
Archived in project
SIG Node PR Triage
Archived in project
SIG Node PR Triage
Done
Milestone
v1.22
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@tanjing2020 @claudiubelu @odinuge @mrunalp @k8s-ci-robot