Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing heading in CHANGELOG #101299

Merged
merged 1 commit into from
Apr 22, 2021
Merged

Add missing heading in CHANGELOG #101299

merged 1 commit into from
Apr 22, 2021

Conversation

jihoon-seo
Copy link
Member

@jihoon-seo jihoon-seo commented Apr 21, 2021 •
edited

What type of PR is this?

/kind documentation
/sig release

What this PR does / why we need it:

'Source Code' heading is missing in CHANGELOG-1.xx.md.

Which issue(s) this PR fixes:

Fixes #101298

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/documentation Categorizes issue or PR as related to documentation. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. sig/release Categorizes an issue or PR as relevant to SIG Release. labels Apr 21, 2021
@k8s-ci-robot
Copy link
Contributor

@jihoon-seo: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/release-eng Issues or PRs related to the Release Engineering subproject labels Apr 21, 2021
@jihoon-seo
Copy link
Member Author

How far back should we backport this change?

@jihoon-seo
Copy link
Member Author

Since this PR updates just 2 Markdown files,
it is weird that some tests fail.

@wilsonehusin
Copy link
Contributor

Are we missing this on other releases too? If so, I'd backport to active release lines.

The failures seem to be from flakes of other tests unrelated to this Markdown.

FYI the block has to be NONE for Prow to mark with release-note-none 😄

/release-note-none
/retest

@k8s-ci-robot
Copy link
Contributor

@wilsonehusin: you can only set the release note label to release-note-none if the release-note block in the PR body text is empty or "none".

In response to this:

Are we missing this on other releases too? If so, I'd backport to active release lines.

The failures seem to be from flakes of other tests unrelated to this Markdown.

FYI the block has to be NONE for Prow to mark with release-note-none 😄

/release-note-none
/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Apr 21, 2021
@jihoon-seo
Copy link
Member Author

jihoon-seo commented Apr 21, 2021 •
edited

@wilsonehusin Thank you for your comment.

FYI the block has to be NONE for Prow to mark with release-note-none 😄

I modified the content of this PR according to your comment. Thanks!

Are we missing this on other releases too? If so, I'd backport to active release lines.

In master branch,
the heading is missing in

In release-1.21 branch,

In release-1.20 branch,

and so on...

@jihoon-seo
Copy link
Member Author

/test pull-kubernetes-e2e-kind

1 similar comment
@jihoon-seo
Copy link
Member Author

/test pull-kubernetes-e2e-kind

@wilsonehusin
Copy link
Contributor

awesome, thanks for the research. let's cover the CHANGELOG/CHANGELOG-1.19.md in this PR and I can approve it to merge.

I find it harder to justify making changes for the ones to release-1.xx branches so I'd say we leave those.

also thanks for being responsive for this! in case you don't know, we usually hangout on Slack (slack.k8s.io) in #release-notes channel. you're welcome to join us if you're interested in this work 😄

@pmmalinov01
Copy link
Contributor

/test pull-kubernetes-e2e-kind

@jihoon-seo jihoon-seo force-pushed the 210421_Add_missing_heading_in_CHANGELOG branch from 0d11ac8 to c91482b Compare April 21, 2021 08:19
@jihoon-seo
Copy link
Member Author

@pmmalinov01 Thanks for re-triggering the failed test.

@wilsonehusin I did another commit, squash, and force-push. PTAL!

Thank you all. :)

@jihoon-seo
Copy link
Member Author

/test pull-kubernetes-conformance-kind-ga-only-parallel

1 similar comment
@pmmalinov01
Copy link
Contributor

/test pull-kubernetes-conformance-kind-ga-only-parallel

@pmmalinov01
Copy link
Contributor

No problem, Thank you for helping out and staying on top of this with faster responses and fixes.

@pmmalinov01
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 21, 2021
@pmmalinov01
Copy link
Contributor

/assign @idealhack

soniasingla
soniasingla reviewed Apr 21, 2021
View reviewed changes
Copy link

@soniasingla soniasingla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @wilsonehusin & @pmmalinov01 for taking care of this!

/lgtm

@idealhack
Copy link
Member

thanks!

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: idealhack, jihoon-seo, pmmalinov01

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 22, 2021
@k8s-ci-robot k8s-ci-robot merged commit d797ece into kubernetes:master Apr 22, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Apr 22, 2021
@jihoon-seo jihoon-seo deleted the 210421_Add_missing_heading_in_CHANGELOG branch April 22, 2021 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soniasingla soniasingla soniasingla left review comments

@melodychn melodychn Awaiting requested review from melodychn

Assignees

@idealhack idealhack

@soniasingla soniasingla

@pmmalinov01 pmmalinov01

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/release Categorizes an issue or PR as relevant to SIG Release. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.22
Development

Successfully merging this pull request may close these issues.

'Source Code' heading is missing in CHANGELOG-1.xx.md
6 participants
@jihoon-seo @k8s-ci-robot @wilsonehusin @pmmalinov01 @idealhack @soniasingla