-
Notifications
You must be signed in to change notification settings - Fork 38.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Limits from scheduling e2e balanced pod resources #101337
Remove Limits from scheduling e2e balanced pod resources #101337
Conversation
The purpose of the pod created by `createBalancedPodForNodes()` is to ensure that all nodes have equal resource requests (as seen by the scheduler). This prevents the default scheduling behavior (which attempts to balance resource requests) from interfering with e2e's which test other priorities/score plugins. Because the scheduler only worries about requests, specifying `Limits` in this pod is unnecessary. In fact, if the calculated "balancing" limit is too low, it can cause the balancing pod to never start due to OOMKill errors, leading to flakes and failures.
@damemi: This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: damemi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/sig scheduling
/cc @Huang-Wei @alculquicondor
For an example of the OOMKill message, see openshift/origin#25915 (comment)
cc @soltysh
Opened a 1.21 backport here #101338 |
/lgtm |
LGTM. |
What type of PR is this?
/kind bug
/kind flake
What this PR does / why we need it:
The purpose of the pod created by
createBalancedPodForNodes()
is to ensurethat all nodes have equal resource requests (as seen by the scheduler). This
prevents the default scheduling behavior (which attempts to balance resource requests)
from interfering with e2e's which test other priorities/score plugins.
Because the scheduler only worries about requests, specifying
Limits
in this podis unnecessary. In fact, if the calculated "balancing" limit is too low, it can cause
the balancing pod to never start due to OOMKill errors, leading to flakes and failures.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: