Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a less-common port for e2e test http pod. #101381

Merged
merged 1 commit into from
Apr 23, 2021
Merged

Use a less-common port for e2e test http pod. #101381

merged 1 commit into from
Apr 23, 2021

Conversation

prameshj
Copy link
Contributor

What type of PR is this?

What this PR does / why we need it:

8080 is a common port that is more likely to cause conflicts when used
in hostNetwork mode for tests. For example - enabling these tests to run along with NodeLocalDNS will fail, since NodeLocalDNS uses 8080 port for healthcheck and runs in hostNetwork mode. The test pods trying to bind to 8080 will fail to schedule in this case.

The nodelocaldns testgrid does not currently run these tests though - https://testgrid.k8s.io/sig-network-gce#gci-gce-coredns-nodecache

Related to #100889 (does not fix it though)

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@prameshj
Use a less-common port for e2e test http pod.
2430f23 
8080 is a common port that is more likely to cause conflicts when used
in hostNetwork mode for tests.
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Apr 22, 2021
@prameshj
Copy link
Contributor Author

/sig network
/kind cleanup
/triage-accepted
/assign @aojea

@k8s-ci-robot k8s-ci-robot added sig/network Categorizes an issue or PR as relevant to SIG Network. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Apr 22, 2021
@k8s-ci-robot k8s-ci-robot added area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Apr 22, 2021
@BenTheElder
Copy link
Member

enabling these tests to run along with NodeLocalDNS will fail, since NodeLocalDNS uses 8080 port for healthcheck and runs in hostNetwork mode.

whoah, seems like nodelocalDNS should really not do that. we should file a seperate issue imho.

@aojea
Copy link
Member

aojea commented Apr 22, 2021

/retest
I wanted to do that before, I don't remember why we didn't move forward with that ... these changes are 😨
once the test pass it LGTM

@prameshj
Copy link
Contributor Author

/triage accepted

Thanks @aojea, the tests have passed now.

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Apr 22, 2021
@prameshj
Copy link
Contributor Author

enabling these tests to run along with NodeLocalDNS will fail, since NodeLocalDNS uses 8080 port for healthcheck and runs in hostNetwork mode.

whoah, seems like nodelocalDNS should really not do that. we should file a seperate issue imho.

I agree, I should have picked a different port for the NodeLocalDNS healthcheck. Since this config has been used for a while now, I am wary of changing it, in case it causes some new conflict on user clusters.

@aojea
Copy link
Member

aojea commented Apr 23, 2021

/lgtm
/Approve
Im afraid of the blast radious, last refactors of these code seems to proper abstract the test from the config and this change shouldn't have any impact .... But we have seen worse, didn't we😂😂
Let's keep an eye on possible issues

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 23, 2021
@BenTheElder
Copy link
Member

I agree, I should have picked a different port for the NodeLocalDNS healthcheck. Since this config has been used for a while now, I am wary of changing it, in case it causes some new conflict on user clusters.

is it at least configurable?

@prameshj
Copy link
Contributor Author

I agree, I should have picked a different port for the NodeLocalDNS healthcheck. Since this config has been used for a while now, I am wary of changing it, in case it causes some new conflict on user clusters.

is it at least configurable?

Yes, the port can be specified in the configmap -

kubernetes/cluster/addons/dns/nodelocaldns/nodelocaldns.yaml

Line 70 in 5209590

health __PILLAR__LOCAL__DNS__:8080

@BenTheElder
Copy link
Member

thanks, sorry for distracting from merging the immediate e2e test
/approve
/priority important-longterm

@k8s-ci-robot k8s-ci-robot added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Apr 23, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea, BenTheElder, prameshj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 23, 2021
@k8s-ci-robot k8s-ci-robot merged commit b11f135 into kubernetes:master Apr 23, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Apr 23, 2021
@prameshj
Copy link
Contributor Author

/lgtm
/Approve
Im afraid of the blast radious, last refactors of these code seems to proper abstract the test from the config and this change shouldn't have any impact .... But we have seen worse, didn't we😂😂
Let's keep an eye on possible issues

True.. was hoping to merge early next week. Didn't add a hold label in time. What dashboards should we refer to? This one?
https://testgrid.k8s.io/sig-release-master-blocking#gce-cos-master-default

@aojea
Copy link
Member

aojea commented Apr 23, 2021

/lgtm
/Approve
Im afraid of the blast radious, last refactors of these code seems to proper abstract the test from the config and this change shouldn't have any impact .... But we have seen worse, didn't wejoyjoy
Let's keep an eye on possible issues

True.. was hoping to merge early next week. Didn't add a hold label in time. What dashboards should we refer to? This one?
https://testgrid.k8s.io/sig-release-master-blocking#gce-cos-master-default

the ci-signal group monitors that and open issues.
I monitor this one https://testgrid.k8s.io/sig-network , it has the nodedns jobs that failed due to the port conflict

@prameshj
Copy link
Contributor Author

the ci-signal group monitors that and open issues.
I monitor this one https://testgrid.k8s.io/sig-network , it has the nodedns jobs that failed due to the port conflict
We don't run nodelocaldns with the hostNetwork pods, AFAICT. My PR was more a proactive fix.

@aojea
Copy link
Member

aojea commented Apr 24, 2021 •
edited

#96453 (comment)
And
Disabled them here kubernetes/test-infra#20224

Can you revert the last pr too?

@prameshj prameshj mentioned this pull request Apr 24, 2021
Merged
@prameshj
Copy link
Contributor Author

#96453 (comment)
And
Disabled them here kubernetes/test-infra#20224

Can you revert the last pr too?

Thanks! I had forgotten we did this.. reverting the PR at kubernetes/test-infra#21936

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alejandrox1 alejandrox1 Awaiting requested review from alejandrox1

@BenTheElder BenTheElder Awaiting requested review from BenTheElder

Assignees

@aojea aojea

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note-none Denotes a PR that doesn't merit a release note. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.22
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@prameshj @BenTheElder @aojea @k8s-ci-robot