Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fieldSelector builder function to events. #101817

Merged
merged 1 commit into from May 14, 2021
Merged

Add fieldSelector builder function to events. #101817

merged 1 commit into from May 14, 2021

Conversation

cndoit18
Copy link
Member

@cndoit18 cndoit18 commented May 8, 2021 •
edited

Signed-off-by: cndoit18 cndoit18@outlook.com

What type of PR is this?

/kind feature
/sig scalability

What this PR does / why we need it:

We want to find its events by object reference, and now the client-go has no expansion method.
this PR adds an expansion to client-go.

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

You can use this Builder function to create events Field Selector

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/feature Categorizes issue or PR as related to a new feature. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 8, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @cndoit18. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label May 8, 2021
@cndoit18
Copy link
Member Author

cndoit18 commented May 8, 2021 •
edited

/assign @liggitt
This is the PR I have reorganized, help to review it, please

@cndoit18 cndoit18 mentioned this pull request May 8, 2021
Closed
@cndoit18 cndoit18 force-pushed the add-events-expansion branch 3 times, most recently from ef3dd7d to ae4d9c5 Compare May 8, 2021 12:16
@cndoit18 cndoit18 requested a review from liggitt May 10, 2021 13:52
@caesarxuchao
Copy link
Member

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 11, 2021
@liggitt
Copy link
Member

liggitt commented May 12, 2021

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 12, 2021
@cndoit18 cndoit18 requested a review from liggitt May 13, 2021 02:15
@cndoit18
Add fieldSelector builder function to events.
678e10f 
Signed-off-by: cndoit18 <cndoit18@outlook.com>
@cndoit18 cndoit18 requested a review from liggitt May 13, 2021 15:02
@liggitt
Copy link
Member

liggitt commented May 14, 2021

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 14, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cndoit18, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 14, 2021
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@cndoit18
Copy link
Member Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit a8f68f9 into kubernetes:master May 14, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone May 14, 2021
@cndoit18 cndoit18 deleted the add-events-expansion branch May 14, 2021 23:40
@jberkus
Copy link

jberkus commented May 17, 2021

Why no release note?

@cndoit18
Copy link
Member Author

cndoit18 commented May 18, 2021 •
edited

Why no release note?

I am sorry. This is my problem, I will add it later.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels May 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brancz brancz Awaiting requested review from brancz

@RainbowMango RainbowMango Awaiting requested review from RainbowMango

@liggitt liggitt Awaiting requested review from liggitt

Assignees

@liggitt liggitt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.22
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@cndoit18 @k8s-ci-robot @caesarxuchao @liggitt @fejta-bot @jberkus