Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

storage e2e: auto detect sector size #101924

Merged
merged 1 commit into from May 12, 2021
Merged

storage e2e: auto detect sector size #101924

merged 1 commit into from May 12, 2021

Conversation

mkimuram
Copy link
Contributor

What type of PR is this?

/kind bug
/kind failing-test

What this PR does / why we need it:

Multi-volume test with block volume mode fails for a backend other than 512KB sector disk, for direct-I/O needs an access with the block size that is aligned to the sector size. This PR add a feature to detect sector size for the test and use the block size detected.

Which issue(s) this PR fixes:

Fixes #101873

Special notes for your reviewer:

/sig storage
/cc @Jiawei0227 @msau42 @nixpanic @jsafrane

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. labels May 11, 2021
@k8s-ci-robot k8s-ci-robot requested a review from msau42 May 11, 2021 22:42
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. sig/storage Categorizes an issue or PR as relevant to SIG Storage. labels May 11, 2021
@k8s-ci-robot
Copy link
Contributor

@mkimuram: GitHub didn't allow me to request PR reviews from the following users: nixpanic.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

What type of PR is this?

/kind bug
/kind failing-test

What this PR does / why we need it:

Multi-volume test with block volume mode fails for a backend other than 512KB sector disk, for direct-I/O needs an access with the block size that is aligned to the sector size. This PR add a feature to detect sector size for the test and use the block size detected.

Which issue(s) this PR fixes:

Fixes #101873

Special notes for your reviewer:

/sig storage
/cc @Jiawei0227 @msau42 @nixpanic @jsafrane

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 11, 2021
@k8s-ci-robot
Copy link
Contributor

@mkimuram: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels May 11, 2021
@mkimuram
Copy link
Contributor Author

@jsafrane

I've tested with csi-hostpath driver by below commands and confirmed that it works.

ENABLE_HOSTPATH_PROVISIONER=true hack/local-up-cluster.sh
make all WHAT=test/e2e/e2e.test
KUBERNETES_PROVIDER=local KUBERNETES_CONFORMANCE_TEST=y
hack/ginkgo-e2e.sh --ginkgo.focus=".*csi-hostpath.*Dynamic PV.*block
volmode.*should concurrently access the single volume from pods on the
same node.*"

I haven't tested with the backend which has 4k sector disk, but the detection logic should work in the same way.
Is it possible to test with your environment? @Jiawei0227

@Jiawei0227
Copy link
Contributor

Is it possible to test with your environment? @Jiawei0227

Unfortunately I dont own the environment so I cannot test it... I think this is looking okay to me as long as it is okay for us to use the JessieDnsutils image instead of the previous one.

nixpanic
nixpanic approved these changes May 12, 2021
View reviewed changes
Copy link
Contributor

@nixpanic nixpanic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for this improvement!

(I'm not part of sig-storage, so I can't /approve)

@jsafrane
Copy link
Member

/lgtm
/approve
Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 12, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane, mkimuram, nixpanic

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 12, 2021
@k8s-ci-robot k8s-ci-robot merged commit 5fedad5 into kubernetes:master May 12, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone May 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nixpanic nixpanic nixpanic approved these changes

@Jiawei0227 Jiawei0227 Awaiting requested review from Jiawei0227

@msau42 msau42 Awaiting requested review from msau42

@jsafrane jsafrane Awaiting requested review from jsafrane

Assignees

@jsafrane jsafrane

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.22
Development

Successfully merging this pull request may close these issues.

e2e storage multivolume block device test takes 512 Bytes sector size by default
5 participants
@mkimuram @k8s-ci-robot @Jiawei0227 @jsafrane @nixpanic