Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Additional cases for reconcileState testing #101909

Merged
merged 1 commit into from
Oct 30, 2021
Merged

Additional cases for reconcileState testing #101909

merged 1 commit into from
Oct 30, 2021

Conversation

nolancon
Copy link

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Additional test cases to exercise new logic in reconcileState introduced by #101771.

Previously, test cases were given an empty lastUpdateState so existing test cases were utilized and passed. This PR adds two new cases with different lastUpdateState data - one requires update, the other does not.

One case also added to test policyRemoveContainerByRef which was previously untested.

Checks also added to test itself to compare actual state vs expected state.

Existing test cases are unchanged.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels May 11, 2021
@k8s-ci-robot k8s-ci-robot added area/kubelet sig/node Categorizes an issue or PR as relevant to SIG Node. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 11, 2021
@nolancon
Copy link
Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label May 11, 2021
@nolancon
Copy link
Author

/cc @klueska

@ehashman ehashman added this to Triage in SIG Node PR Triage May 12, 2021
@SergeyKanzhelev
Copy link
Member

/area test

/assign @fromanirh
/triage accepted
/priority important-longterm

@k8s-ci-robot k8s-ci-robot added area/test triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels May 12, 2021
@SergeyKanzhelev SergeyKanzhelev moved this from Triage to Needs Reviewer in SIG Node PR Triage May 12, 2021
@klueska
Copy link
Contributor

klueska commented May 12, 2021 •
edited

/hold

@nolancon, I'm inclined to wait to merge this until after #101432 has been merged so as not to force @fromanirh to do yet another rebase to incorporate these changes.

It means, however, that you will need to rebase once his changes are in. Does that work for you?

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 12, 2021
@nolancon
Copy link
Author

/hold

@nolancon, I'm inclined to wait to merge this until after #101432 has been merged so as not to force @fromanirh to do yet another rebase to incorporate these changes.

It means, however, that you will need to rebase once his changes are in. Does that work for you?

Sure, that works for me. No rush with this anyway.

@SergeyKanzhelev SergeyKanzhelev moved this from Triage to PRs - Needs Reviewer in SIG Node CI/Test Board May 16, 2021
@ehashman ehashman moved this from PRs - Needs Reviewer to PRs Waiting on Author in SIG Node CI/Test Board May 25, 2021
@SergeyKanzhelev SergeyKanzhelev moved this from PRs Waiting on Author to PRs - Needs Reviewer in SIG Node CI/Test Board Sep 22, 2021
@klueska
Copy link
Contributor

klueska commented Oct 1, 2021

Sorry for the delay on this. It got lost in the backlog.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 1, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: klueska, nolancon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 1, 2021
@nolancon
Copy link
Author

nolancon commented Oct 5, 2021

Sorry for the delay on this. It got lost in the backlog.

/lgtm
/approve

Thanks @klueska, looks like this is stuck on hold.

@klueska
Copy link
Contributor

klueska commented Oct 5, 2021

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 5, 2021
@nolancon
Copy link
Author

nolancon commented Oct 6, 2021

/pull-kubernetes-node-e2e-containerd

@klueska
Copy link
Contributor

klueska commented Oct 11, 2021

/test pull-kubernetes-node-e2e-containerd

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 11, 2021
@nolancon
Copy link
Author

/retest

@SergeyKanzhelev
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 30, 2021
@k8s-ci-robot k8s-ci-robot merged commit 08bf546 into kubernetes:master Oct 30, 2021
SIG Node CI/Test Board automation moved this from PRs - Needs Reviewer to Done Oct 30, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Oct 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klueska klueska Awaiting requested review from klueska

@krmayankk krmayankk Awaiting requested review from krmayankk

Assignees

@klueska klueska

@SergeyKanzhelev SergeyKanzhelev

@ffromani ffromani

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node CI/Test Board
Done
SIG Node CI/Test Board
Archived in project
SIG Node PR Triage
Archived in project
SIG Node PR Triage
Needs Reviewer
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@nolancon @SergeyKanzhelev @klueska @k8s-ci-robot @ffromani