Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log if PV is still in use trying to delete it #101987

Merged
merged 1 commit into from
Sep 23, 2021
Merged

Log if PV is still in use trying to delete it #101987

merged 1 commit into from
Sep 23, 2021

Conversation

sky-philipalmeida
Copy link
Contributor

Similar to what we have in:
https://github.com/kubernetes/kubernetes/blob/master/pkg/controller/volume/pvcprotection/pvc_protection_controller.go#L181
The objective is to have a easy way to monitor if a PV will enter in Terminating state due to a failed removal when still in use.
This way we can capture the PV log and alert according.
The code is not tested.

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 13, 2021
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 13, 2021
@k8s-ci-robot
Copy link
Contributor

@sky-philipalmeida: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

Welcome @sky-philipalmeida!

It looks like this is your first PR to kubernetes/kubernetes 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kubernetes has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 13, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @sky-philipalmeida. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label May 13, 2021
@k8s-ci-robot k8s-ci-robot added sig/apps Categorizes an issue or PR as relevant to SIG Apps. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 13, 2021
@sky-philipalmeida
Copy link
Contributor Author

I have sign it!

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels May 13, 2021
@xing-yang
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 19, 2021
@xing-yang
Copy link
Contributor

/kind cleanup

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels May 19, 2021
@xing-yang
Copy link
Contributor

/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels May 19, 2021
@sky-philipalmeida
Copy link
Contributor Author

sky-philipalmeida commented May 20, 2021 •
edited

Not sure what is failing can you please help?
I have compile it with the code changes no errors there :)

@sky-philipalmeida
Copy link
Contributor Author

/retest

@sky-philipalmeida
Copy link
Contributor Author

/retest-required

@sky-philipalmeida
Copy link
Contributor Author

sky-philipalmeida commented Sep 23, 2021 •
edited

@xing-yang do I need to to anything else?
The CI process seems to be pending for a long time.
I have triggered a retest but still see pending 16.

@xing-yang
Copy link
Contributor

/test pull-kubernetes-e2e-gce-storage-slow

@xing-yang
Copy link
Contributor

/retest

@xing-yang
Copy link
Contributor

/test pull-kubernetes-conformance-kind-ga-only-parallel

@xing-yang
Copy link
Contributor

/test pull-kubernetes-dependencies

@xing-yang
Copy link
Contributor

/test pull-kubernetes-e2e-gce-100-performance

@xing-yang
Copy link
Contributor

/test pull-kubernetes-e2e-gce-csi-serial

@xing-yang
Copy link
Contributor

/test pull-kubernetes-e2e-gce-storage-snapshot

@xing-yang
Copy link
Contributor

/test pull-kubernetes-e2e-gce-ubuntu-containerd

@xing-yang
Copy link
Contributor

/test pull-kubernetes-e2e-kind

@xing-yang
Copy link
Contributor

/test pull-kubernetes-e2e-kind-ipv6

@xing-yang
Copy link
Contributor

/test pull-kubernetes-integration

@xing-yang
Copy link
Contributor

/test pull-kubernetes-node-e2e-containerd

@xing-yang
Copy link
Contributor

/test pull-kubernetes-typecheck

@xing-yang
Copy link
Contributor

/test pull-kubernetes-unit

@xing-yang
Copy link
Contributor

/test pull-kubernetes-verify

@xing-yang
Copy link
Contributor

/test pull-kubernetes-verify-govet-levee

@xing-yang
Copy link
Contributor

/sig storage

@k8s-ci-robot k8s-ci-robot added the sig/storage Categorizes an issue or PR as relevant to SIG Storage. label Sep 23, 2021
@xing-yang
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 23, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sky-philipalmeida, xing-yang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 23, 2021
@k8s-ci-robot k8s-ci-robot merged commit b692483 into kubernetes:master Sep 23, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Sep 23, 2021
@coderanger
Copy link
Member

@sky-philipalmeida If the goal is to expose this to end users, maybe we should set up a counter metric for it too? Would make it easier to watch on large fleets.

@sky-philipalmeida
Copy link
Contributor Author

sky-philipalmeida commented Sep 29, 2021 •
edited

@sky-philipalmeida If the goal is to expose this to end users, maybe we should set up a counter metric for it too? Would make it easier to watch on large fleets.

Yes that would be the best approach as we could also monitor it via Prometheus.
But this should also be applied to PVC

Atm I do not have the required knowledge to implement this to be honest, I know maybe kube-state-metrics integration would be the way to go.

@coderanger
Copy link
Member

Please feel free to reach out to SIG-Instrumentation on Slack if you'd like help setting up a metric :)

@sky-philipalmeida
Copy link
Contributor Author

Thanks @coderanger

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rootfs rootfs Awaiting requested review from rootfs

@xing-yang xing-yang Awaiting requested review from xing-yang

Assignees

@xing-yang xing-yang

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@sky-philipalmeida @k8s-ci-robot @xing-yang @k8s-triage-robot @coderanger