Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable more test images for s390x #102785

Merged
merged 2 commits into from
Oct 19, 2021
Merged

Enable more test images for s390x #102785

merged 2 commits into from
Oct 19, 2021

Conversation

yselkowitz
Copy link
Contributor

What type of PR is this?

/kind bug
/kind failing-test

What this PR does / why we need it:

This enables the build of more test images on s390x so that the tests which depend thereon pass on s390x.

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/bug Categorizes issue or PR as related to a bug. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jun 10, 2021
@k8s-ci-robot
Copy link
Contributor

Welcome @yselkowitz!

It looks like this is your first PR to kubernetes/kubernetes 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kubernetes has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @yselkowitz. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jun 10, 2021
@dims
Copy link
Member

dims commented Jun 10, 2021

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 10, 2021
@BenTheElder
Copy link
Member

These images are for node and storage tests. I'm not sure if we have automated builds for them yet.
/sig node
/sig storage

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. labels Jun 10, 2021
@mkumatag
Copy link
Member

These images are for node and storage tests. I'm not sure if we have automated builds for them yet.
/sig node
/sig storage

At least we should test image building part once before we merge..

@ehashman ehashman added this to Triage in SIG Node CI/Test Board Jun 11, 2021
@ehashman
Copy link
Member

/priority backlog
/triage accepted

@k8s-ci-robot k8s-ci-robot added priority/backlog Higher priority than priority/awaiting-more-evidence. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jun 11, 2021
@ehashman ehashman moved this from Triage to PRs Waiting on Author in SIG Node CI/Test Board Jun 11, 2021
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 7, 2021
@yselkowitz
Copy link
Contributor Author

Updating the base to 3.14 seems to work.

@yselkowitz yselkowitz mentioned this pull request Oct 7, 2021
Closed
@mkumatag
Copy link
Member

mkumatag commented Oct 7, 2021

Updating the base to 3.14 seems to work.

it will be great if you can attach image building logs to this PR for reference for all the images.

@yselkowitz
Copy link
Contributor Author

/retest

@yselkowitz
Copy link
Contributor Author

Ping?

@mkumatag
Copy link
Member

Ping?

Seems like there isn't a CI run for building these images, if you have image building logs handy please attach it here..

@yselkowitz
Copy link
Contributor Author

I did not keep logs, but I did build them.

@mkumatag
Copy link
Member

I did not keep logs, but I did build them.

Let's merge this, will fix the errors if any..

mkumatag
mkumatag approved these changes Oct 19, 2021
View reviewed changes
Copy link
Member

@mkumatag mkumatag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 19, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mkumatag, yselkowitz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 19, 2021
@yselkowitz
Copy link
Contributor Author

Failure is completely unrelated.
/retest

@k8s-ci-robot k8s-ci-robot merged commit b977200 into kubernetes:master Oct 19, 2021
SIG Node CI/Test Board automation moved this from PRs Waiting on Author to Done Oct 19, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Oct 19, 2021
yselkowitz added a commit to yselkowitz/kubernetes that referenced this pull request Oct 19, 2021
@yselkowitz
test: use newer test images for better s390x coverage
4e3f94e 
These image versions added s390x builds via
kubernetes#102785.
@yselkowitz yselkowitz mentioned this pull request Oct 19, 2021
Merged
@mkumatag
Copy link
Member

one of the post-job failed - https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/post-kubernetes-push-e2e-node-perf-npb-is-test-images/1450295575680389120

@claudiubelu can you please retrigger the job?

@mkumatag mkumatag mentioned this pull request Oct 21, 2021
Merged
@mkumatag
Copy link
Member

one of the post-job failed - https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/post-kubernetes-push-e2e-node-perf-npb-is-test-images/1450295575680389120

@claudiubelu can you please retrigger the job?

pushed the image now via - #105823 (comment)

@mkumatag mkumatag mentioned this pull request Oct 22, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkumatag mkumatag mkumatag approved these changes

@dims dims Awaiting requested review from dims

@claudiubelu claudiubelu Awaiting requested review from claudiubelu

Assignees

@mkumatag mkumatag

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/backlog Higher priority than priority/awaiting-more-evidence. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node CI/Test Board
Done
SIG Node CI/Test Board
Archived in project
SIG Node PR Triage
Archived in project
SIG Node PR Triage
Triage
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@yselkowitz @k8s-ci-robot @dims @BenTheElder @mkumatag @ehashman @SergeyKanzhelev @hbrueckner @cwsolee