update Azure/go-ansiterm to v0.0.0-20210617225240-d185dfc1b5a1

[BenTheElder]

fixes constant overflow compiling for windows/386

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #102988 <-- we don't have passing release builds right now (!)

Special notes for your reviewer:

see: Azure/go-ansiterm@d185dfc

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

/sig windows
/sig release
/priority critical-urgent

[BenTheElder]

/test pull-kubernetes-cross

[BenTheElder]

/triage accepted

[BenTheElder]

it's too bad hack/update-vendor.sh or hack/pin-dependency.sh isn't smart enough to do https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/103010/pull-kubernetes-dependencies/1406012178892328960 for me automatically:

These modules are pinned to versions different than the minimal preferred version.
That means that without replace directives, a different version would be selected,
which breaks consumers of our published modules.
1. Use hack/pin-dependency.sh to switch to the preferred version for each module
2. Run hack/update-vendor.sh to rebuild the vendor directory
3. Run hack/lint-dependencies.sh to verify no additional changes are required

golang.org/x/sys
    pinned:    v0.0.0-20210603081109-ebe580a85c40
    preferred: v0.0.0-20210616094352-59db8d763f22
    hack/pin-dependency.sh golang.org/x/sys v0.0.0-20210616094352-59db8d763f22
All pinned versions of checked dependencies match their preferred version.

[aojea]

golang.org/x/sys
    pinned:    v0.0.0-20210603081109-ebe580a85c40
    preferred: v0.0.0-20210616094352-59db8d763f22
    hack/pin-dependency.sh golang.org/x/sys v0.0.0-20210616094352-59db8d763f22
All pinned versions of checked dependencies match their preferred version.

EDIT

too late

[BenTheElder]

ran steps from above #103010 (comment). hack/lint-dependencies.sh reports nothing now.

/test pull-kubernetes-cross

[BenTheElder]

deps job is happy, but the real test here is https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/103010/pull-kubernetes-cross/1406015495873761280

[BenTheElder]

I guess lint-deps and update-vendor don't check internal modules ..?

added a ./hack/update-internal-modules.sh to the commit

[BenTheElder]

/test pull-kubernetes-cross

[dims]

/assign @liggitt

/approve
(not that i'd make a difference as i don't have enough karma!)

[BenTheElder]

Errors from staticcheck:
cluster/images/etcd/migrate/versions.go:129:1: this linter directive didn't match anything; should it be removed? ()
cluster/images/etcd/migrate/versions.go:192:1: this linter directive didn't match anything; should it be removed? ()

Please review the above warnings. You can test via:
  hack/verify-staticcheck.sh <failing package>
If the above warnings do not make sense, you can exempt the line or file. See:
  https://staticcheck.io/docs/#ignoring-problems

https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/103010/pull-kubernetes-verify/1406027044235513856
🤨
/retest

[BenTheElder]

cross build is green 👍

verify is a known linter flake class with "is this method used or dead code" + methods used by unit tests

[liggitt]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, dims, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [liggitt]
• staging/src/k8s.io/api/OWNERS [liggitt]
• staging/src/k8s.io/legacy-cloud-providers/OWNERS [dims,liggitt]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[BenTheElder]

still needs a /lgtm for merge. tests are good now.

[dims]

/lgtm