Fix scheduler extenders being not called on preemptions

[ordovicia]

What type of PR is this?

/kind bug
/sig scheduling

What this PR does / why we need it:

This PR fixes a bug that scheduler extenders are not called on preemptions because frameworkImpl.extenders is not set.

Which issue(s) this PR fixes:

Fixes #102971

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

Fixed a regression in 1.20+ scheduler extender setup that scheduler extenders are not called on preemptions

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

[k8s-ci-robot]

Welcome @ordovicia!

It looks like this is your first PR to kubernetes/kubernetes 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kubernetes has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @ordovicia. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[ahg-g]

/ok-to-test

[ahg-g]

/lgtm
/approve

[ahg-g]

Can you please create a cherry pick to 1.21 and 1.20 once this is merged?

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g, ordovicia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/scheduler/OWNERS [ahg-g]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ordovicia]

@ahg-g Thank you for your review. I have submitted cherry-pick PRs: #103030, #103031

[ahg-g]

Thanks, it would be great if you can add an integration test to https://github.com/kubernetes/kubernetes/blob/master/test/integration/scheduler/extender_test.go

[RyanBouchard]

@ordovicia I'm interested in adding this integration test, may I take it?

[ahg-g]

pls go ahead.

[RyanBouchard]

Thank you! I will start working on that.

[cpanato]

/triage accepted
/priority important-soon

[RyanBouchard]

@ordovicia @ahg-g I apologize for the long absence. I originally working on adding an integration test, then I discussed with Huang-Wei about covering this with a unit test instead; however, other things have since come up, and I don't think I will get to this in a reasonable amount of time. I closed my PR to avoid holding things up any further. I believe a test is still needed.