-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove not used IsStaticPod, prevent possible panic #103048
Conversation
Hi @gy95. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/release-note-none |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
/priority backlog
/triage accepted
/lgtm
Assuming tests pass, I agree this is unused in favour of
kubernetes/pkg/kubelet/types/pod_update.go
Lines 149 to 153 in 671251a
// IsStaticPod returns true if the pod is a static pod. | |
func IsStaticPod(pod *v1.Pod) bool { | |
source, err := GetPodSource(pod) | |
return err == nil && source != ApiserverSource | |
} |
See https://cs.k8s.io/?q=IsStaticPod&i=nope&files=&excludeFiles=&repos=kubernetes/kubernetes
/test pull-kubernetes-e2e-gce-100-performance |
ping |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gy95, mrunalp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
IsStaticPod
is never usedkubernetes/pkg/kubelet/pod/mirror_client.go
Lines 156 to 160 in 513ae55
And there is the same function in
kubernetes/pkg/kubelet/types/pod_update.go
Lines 149 to 153 in 513ae55
So we can remove the first definition
func IsMirrorPod(pod *v1.Pod) bool
doesn't check whetherAnnotations
is nil or not.but in the function above
IsStaticPod
, it callsGetPodSource
, and this function check whetherAnnotations
is nil or notkubernetes/pkg/kubelet/types/pod_update.go
Lines 104 to 111 in 513ae55
i think we can check also, but i'm not very sure it is need to check.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: