Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PodSecurity: make failure integration tests feature-aware #103365

Merged
merged 2 commits into from Jul 1, 2021
Merged

PodSecurity: make failure integration tests feature-aware #103365

merged 2 commits into from Jul 1, 2021

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Jun 30, 2021

What type of PR is this?

/kind feature
/kind test

What this PR does / why we need it:

Enables the failure testcases for podsecurity tests to indicate features they depend on (for example, features which must be enabled for data to be persisted in the fields the negative testcase expects to reject).

It also runs the integration tests with only GA features to ensure passing testcases only depend on GA features.

This unblocks adding testcases for procMount (xref #103340 (comment))

Does this PR introduce a user-facing change?

NONE

/assign @tallclair

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Jun 30, 2021
@k8s-ci-robot
Copy link
Contributor

@liggitt: The label(s) kind/test cannot be applied, because the repository doesn't have them.

In response to this:

What type of PR is this?

/kind feature
/kind test

What this PR does / why we need it:

Enables the failure testcases for podsecurity tests to indicate features they depend on (for example, features which must be enabled for data to be persisted in the fields the negative testcase expects to reject).

It also runs the integration tests with only GA features to ensure passing testcases only depend on GA features.

This unblocks adding testcases for procMount (xref #103340 (comment))

Does this PR introduce a user-facing change?

NONE

/assign @tallclair

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jun 30, 2021
@liggitt liggitt added this to In Review in SIG-Auth: PodSecurity via automation Jun 30, 2021
@liggitt liggitt added this to the v1.22 milestone Jun 30, 2021
@liggitt
Copy link
Member Author

liggitt commented Jun 30, 2021

/sig auth

@k8s-ci-robot k8s-ci-robot added sig/auth Categorizes an issue or PR as relevant to SIG Auth. approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jun 30, 2021
@liggitt liggitt mentioned this pull request Jun 30, 2021
Merged
@MadhavJivrajani
Copy link
Contributor

/triage accepted
/priority important-soon
Thanks! :)

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jun 30, 2021
@k8s-ci-robot k8s-ci-robot added the area/dependency Issues or PRs related to dependency changes label Jun 30, 2021
@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 30, 2021
tallclair
tallclair approved these changes Jun 30, 2021
View reviewed changes
Copy link
Member

@tallclair tallclair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
(once you figure out the restore issue)

test/integration/auth/podsecurity_test.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added the sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. label Jun 30, 2021
@liggitt
Copy link
Member Author

liggitt commented Jun 30, 2021

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 30, 2021
@tallclair
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 30, 2021
@liggitt liggitt mentioned this pull request Jun 30, 2021
Merged
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@k8s-ci-robot k8s-ci-robot added area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Jun 30, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, tallclair

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@liggitt
Copy link
Member Author

liggitt commented Jun 30, 2021 •
edited

fixed import verify error

@liggitt liggitt added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 30, 2021
@liggitt liggitt moved this from In Review to Done in SIG-Auth: PodSecurity Jun 30, 2021
@liggitt
Copy link
Member Author

liggitt commented Jun 30, 2021

/retest

@liggitt liggitt mentioned this pull request Jun 30, 2021
Merged
@liggitt
Copy link
Member Author

liggitt commented Jul 1, 2021

fixed conflict

@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 1, 2021
@liggitt liggitt added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 1, 2021
@liggitt
Copy link
Member Author

liggitt commented Jul 1, 2021

/retest

@liggitt
Copy link
Member Author

liggitt commented Jul 1, 2021

#102904 flake

@k8s-ci-robot k8s-ci-robot merged commit dbfea1e into kubernetes:master Jul 1, 2021
@liggitt liggitt deleted the podsecurity-feature-test branch July 1, 2021 12:59
@liggitt liggitt mentioned this pull request Jul 10, 2021
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tallclair tallclair tallclair approved these changes

@aojea aojea Awaiting requested review from aojea

@krmayankk krmayankk Awaiting requested review from krmayankk

Assignees

@tallclair tallclair

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dependency Issues or PRs related to dependency changes area/release-eng Issues or PRs related to the Release Engineering subproject area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG-Auth: PodSecurity
Done (1.22, Alpha)
Milestone
v1.22
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@liggitt @k8s-ci-robot @MadhavJivrajani @tallclair