Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #103385: Ensure proper resource creation #103404

Merged
merged 1 commit into from
Jan 7, 2022
Merged

Automated cherry pick of #103385: Ensure proper resource creation #103404

merged 1 commit into from
Jan 7, 2022

Conversation

ravisantoshgudimetla
Copy link
Contributor

Cherry pick of #103385 on release-1.21.

#103385: Ensure proper resource creation

For details on the cherry pick process, see the cherry pick requests page.

@ravisantoshgudimetla
Ensure proper resource creation
14f35ad 
Ensure resources are created in zone with schedulable
nodes. For example, if we have 4 zones with 3 zones
having worker nodes and 1 zone having master nodes(unscheduable
for workloads), we should not create resources like PV, PVC or
pods in that zone.
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Jul 1, 2021
@k8s-ci-robot k8s-ci-robot added the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Jul 1, 2021
@k8s-ci-robot
Copy link
Contributor

@ravisantoshgudimetla: This cherry pick PR is for a release branch and has not yet been approved by Release Managers.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick, it must first be approved (/lgtm + /approve) by the relevant OWNERS.

AFTER it has been approved by code owners, please ping the kubernetes/release-managers team in a comment to request a cherry pick review.

(For details on the patch release process and schedule, see the Patch Releases page.)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework labels Jul 1, 2021
@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. area/test sig/storage Categorizes an issue or PR as relevant to SIG Storage. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. sig/testing Categorizes an issue or PR as relevant to SIG Testing. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jul 1, 2021
@ravisantoshgudimetla
Copy link
Contributor Author

cc @msau42 @mattcary

@mattcary
Copy link
Contributor

mattcary commented Jul 1, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 1, 2021
@msau42
Copy link
Member

msau42 commented Jul 1, 2021

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 1, 2021
@mattcary
Copy link
Contributor

@ravisantoshgudimetla Can you add the release note as described above, then ping kubernetes/release-managers to get this cherry pick merged?

@cpanato
Copy link
Member

cpanato commented Aug 6, 2021

@mattcary @ravisantoshgudimetla this looks like the kind of a feature, this is fixing any issue/bug? I did not find an issue that explains this code change.
Can you please clarify? thanks!

@cpanato
Copy link
Member

cpanato commented Aug 6, 2021

/hold for clarifications

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 6, 2021
@saschagrunert
Copy link
Member

@mattcary @ravisantoshgudimetla what do we wanna do with this one?

@mattcary
Copy link
Contributor

/release-note none

Oh, I spaced this is only fixing e2e test. So no release note is needed.

The root pr for this (#103385) explains the motivation---it makes the e2e tests less flakey.

@mattcary
Copy link
Contributor

/release-note-note

@mattcary
Copy link
Contributor

/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Oct 29, 2021
@mattcary
Copy link
Contributor

/kind cleanup

(from #103385)

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Oct 29, 2021
@mattcary
Copy link
Contributor

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 29, 2021
@cpanato
Copy link
Member

cpanato commented Dec 10, 2021

@mattcary this is needed only in 1.21 or do we need to backport this to 1.20 as well?

@mattcary
Copy link
Contributor

It's only touching tests, so is safe to backport. It reduces test flakiness, so would be nice to backport all the way to 1.20. However, since 1.20 is going to be falling off the testgrid soon anyway (IIUC), it's not critical.

@cpanato
Copy link
Member

cpanato commented Dec 14, 2021

thanks @mattcary for the clarifications

cpanato
cpanato approved these changes Jan 7, 2022
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@cpanato
Copy link
Member

cpanato commented Jan 7, 2022

/triage accepted
/priority important-soon

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jan 7, 2022
@cpanato cpanato added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jan 7, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Jan 7, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, msau42, ravisantoshgudimetla

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 70a65c3 into kubernetes:release-1.21 Jan 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpanato cpanato cpanato approved these changes

@fabriziopandini fabriziopandini Awaiting requested review from fabriziopandini

@gnufied gnufied Awaiting requested review from gnufied

Assignees

@cpanato cpanato

@mattcary mattcary

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework area/test cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@ravisantoshgudimetla @k8s-ci-robot @mattcary @msau42 @cpanato @saschagrunert