Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: return empty VMAS name if using standalone VM #103470

Merged
merged 1 commit into from Jul 8, 2021
Merged

fix: return empty VMAS name if using standalone VM #103470

merged 1 commit into from Jul 8, 2021

Conversation

nilo19
Copy link
Member

@nilo19 nilo19 commented Jul 5, 2021

What type of PR is this?

/kind bug

What this PR does / why we need it:

Cherry-pick from kubernetes-sigs/cloud-provider-azure#679: fix: return empty VMAS name if using standalone VM.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

fix: return empty VMAS name if using standalone VM

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

/triage accepted
/sig cloud-provider
/area provider/azure
/priority critical-urgent
cc @feiskyer

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/provider/azure Issues or PRs related to azure provider priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. area/cloudprovider and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jul 5, 2021
feiskyer
feiskyer approved these changes Jul 5, 2021
View reviewed changes
Copy link
Member

@feiskyer feiskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 5, 2021
@nilo19
Copy link
Member Author

nilo19 commented Jul 5, 2021

/assign @cheftako

@ialidzhikov
Copy link
Contributor

@cheftako , could you please check this PR? Thanks in advance!

@dims
Copy link
Member

dims commented Jul 8, 2021

/approve
/milestone v1.22

@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Jul 8, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, feiskyer, nilo19

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 8, 2021
@k8s-ci-robot k8s-ci-robot merged commit 103212f into kubernetes:master Jul 8, 2021
@nilo19 nilo19 deleted the bug/cherry-pick-679 branch July 9, 2021 01:32
This was referenced Jul 9, 2021
Merged
Merged
k8s-ci-robot added a commit that referenced this pull request Jul 16, 2021
@k8s-ci-robot
Merge pull request #103599 from nilo19/automated-cherry-pick-of-#1034…
6c460e6 
…70-upstream-release-1.21

Cherry pick of #103470: fix: return empty VMAS name if using standalone VM
k8s-ci-robot added a commit that referenced this pull request Jul 16, 2021
@k8s-ci-robot
Merge pull request #103600 from nilo19/automated-cherry-pick-of-#1034…
c0f757a 
…70-upstream-release-1.20

Cherry pick of #103470: fix: return empty VMAS name if using standalone VM
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feiskyer feiskyer feiskyer approved these changes

@brendandburns brendandburns Awaiting requested review from brendandburns

@khenidak khenidak Awaiting requested review from khenidak

Assignees

@feiskyer feiskyer

@cheftako cheftako

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cloudprovider area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.22
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@nilo19 @ialidzhikov @dims @k8s-ci-robot @feiskyer @cheftako