Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get golangci lint back on its feet #103650

Merged
merged 4 commits into from Jul 15, 2021
Merged

Get golangci lint back on its feet #103650

merged 4 commits into from Jul 15, 2021

Conversation

dims
Copy link
Member

@dims dims commented Jul 12, 2021 •
edited

What type of PR is this?

hack/verify-golangci-lint.sh has bit-rotted as it is not run anywhere, easy to resurrect this script with an update to go.mod/sum. The deadcode/varcheck/ineffassign has caught a few more things. Let's enable running this new check again please.

/kind cleanup

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/apiserver area/cloudprovider area/code-generation area/dependency Issues or PRs related to dependency changes area/kubectl area/kubelet area/test sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jul 12, 2021
@k8s-ci-robot k8s-ci-robot requested review from andrewsykim, bobbypage and a team July 12, 2021 23:22
@k8s-ci-robot k8s-ci-robot added sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/storage Categorizes an issue or PR as relevant to SIG Storage. labels Jul 12, 2021
@dims
Copy link
Member Author

dims commented Jul 13, 2021

/retest

@dims dims force-pushed the get-golangci-lint-back-on-its-feet branch from 36eca59 to 5e6d311 Compare July 13, 2021 13:15
@dims
Copy link
Member Author

dims commented Jul 13, 2021

/test pull-kubernetes-e2e-gce-ubuntu-containerd

@dims
Copy link
Member Author

dims commented Jul 13, 2021

/skip

thockin
thockin reviewed Jul 13, 2021
View reviewed changes
Copy link
Member

@thockin thockin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought I sent this last night, but I guess not :(

pkg/apis/storage/validation/validation_test.go Outdated Show resolved Hide resolved
pkg/apis/storage/validation/validation_test.go Outdated Show resolved Hide resolved
test/e2e/common/node/pods.go Outdated Show resolved Hide resolved
pkg/kubelet/certificate/bootstrap/bootstrap_test.go Outdated Show resolved Hide resolved
@SergeyKanzhelev SergeyKanzhelev moved this from Triage to Archive-it in SIG Node CI/Test Board Jul 13, 2021
@ehashman ehashman added this to Waiting on Author in SIG Node PR Triage Jul 13, 2021
dims added 4 commits July 14, 2021 08:41
@dims
update golangci-lint to newer version
b74fe23 
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
@dims
fix deadcode issues
26cc8e4 
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
@dims
fix ineffassign and varcheck
07332ad 
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
@dims
enable verify-golangci-lint.sh
75748c1 
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
@dims dims force-pushed the get-golangci-lint-back-on-its-feet branch from 5e6d311 to 75748c1 Compare July 14, 2021 12:53
@dims
Copy link
Member Author

dims commented Jul 14, 2021

@thockin resolved all the comments. thanks!

@thockin
Copy link
Member

thockin commented Jul 14, 2021

Thanks!

/lgtm
/approve
/retest

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 14, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 14, 2021
@dims
Copy link
Member Author

dims commented Jul 14, 2021

/milestone v1.22

@kubernetes/release-team the linters we had were failing silently as we did not have CI running, we cleanup here and get the verify script back on its feet, so it's part bug / part cleanup.

@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Jul 14, 2021
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@aojea
Copy link
Member

aojea commented Jul 14, 2021

👍

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jul 15, 2021 •
edited

@dims: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Rerun command
pull-kubernetes-e2e-aks-engine-windows-containerd 201591194c748864ca20f68721613c183054afbc link /test pull-kubernetes-e2e-aks-engine-windows-containerd
check-dependency-stats 201591194c748864ca20f68721613c183054afbc link /test check-dependency-stats

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@cpanato
Copy link
Member

cpanato commented Jul 15, 2021

/test pull-kubernetes-e2e-gce-ubuntu-containerd

@cpanato
Copy link
Member

cpanato commented Jul 15, 2021

thanks Dims
from RelEng:
/lgtm

@k8s-ci-robot k8s-ci-robot merged commit 02355e2 into kubernetes:master Jul 15, 2021
SIG Node CI/Test Board automation moved this from Archive-it to Done Jul 15, 2021
This was referenced Jul 15, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thockin thockin thockin left review comments

@msau42 msau42 msau42 left review comments

@mattcary mattcary mattcary left review comments

@andrewsykim andrewsykim Awaiting requested review from andrewsykim

@bobbypage bobbypage Awaiting requested review from bobbypage

Assignees

@liggitt liggitt

@cpanato cpanato

@thockin thockin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/cloudprovider area/code-generation area/dependency Issues or PRs related to dependency changes area/kubectl area/kubelet area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node CI/Test Board
Done
SIG Node CI/Test Board
Archived in project
SIG Node PR Triage
Waiting on Author
Milestone
v1.22
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@dims @thockin @k8s-ci-robot @fejta-bot @aojea @cpanato @msau42 @mattcary @liggitt