-
Notifications
You must be signed in to change notification settings - Fork 38.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove pkg/utils/slice dependeny in kube-proxy #103672
Conversation
@uablrek: This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Converted to draft. Obviously just updating vendor/ is not the way to go. Nothing works and all sig's and area's were added. |
Commands executed;
|
/remove-sig api-machinery |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Should we leave a pointer in pkg/utils telling new users not to use it?
Will you also follow up with the last users of it?
/lgtm
/approve
/lgtm |
ce674cc
to
c3509f4
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cheftako, thockin, uablrek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
As a step towards move pkg/proxy to k8s.io/kube-proxy the
pkg/utils/slice
package is replaced withk8s.io/utils/strings/slices
, see kubernetes/utils#208.The
k8s.io/utils/strings/slices
is in turn intended to be replaced with the standard "slices" package proposed in golang/go#45955.Which issue(s) this PR fixes:
Part of #92369
Special notes for your reviewer:
The update of the
k8s.io/utils
version should probably not be done in this PR but in some more controlled way. I am not familiar with the procedure but the update is kept in it's own commit (which should not be reviewed).Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
N/A