Make --configure-cloud-routes configurable in local-up-cluster #103710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
- Allow --configure-cloud-routes to be set in hack/local-up-cluster.sh using the env var $CONFIGURE_CLOUD_ROUTES.
nckturner
force-pushed
the
configure-cloud-routes-local-hack
branch
from
dc9a9e6
to
1887ddf
Compare
|
/sig cloud-provider |
k8s-ci-robot
added
sig/cloud-provider
|
/assign @cheftako |
|
/triage accepted |
k8s-ci-robot
added
triage/accepted
|
/retest |
dims
reviewed
Jul 15, 2021
| @@ -653,6 +654,7 @@ function start_controller_manager { | |||
| fi | |||
|
|
|||
| cloud_config_arg=("--cloud-provider=${CLOUD_PROVIDER}" "--cloud-config=${CLOUD_CONFIG}") | |||
| cloud_config_arg+=("--configure-cloud-routes=${CONFIGURE_CLOUD_ROUTES}") | |||
There was a problem hiding this comment.
@nckturner is true the current default if --configure-cloud-routes is not specified in the command line?
There was a problem hiding this comment.
Yes, that is correct.
|
/approve though this will have to wait until 1.23 due to code freeze. |
k8s-ci-robot
added
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dims, fejta, nckturner The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/milestone v1.23 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
using the env var $CONFIGURE_CLOUD_ROUTES.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Additional configuration option for
hack/local-up-cluster.sh.Does this PR introduce a user-facing change?