Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass unknown labels in allowedTopologies during CSI translation #103750

Merged
merged 1 commit into from Aug 5, 2021
Merged

Pass unknown labels in allowedTopologies during CSI translation #103750

merged 1 commit into from Aug 5, 2021

Conversation

mattcary
Copy link
Contributor

Ignore unknown labels while doing translation of allowed topologies.

Fixes #103749

/kind bug

None

/sig storage
/assign @msau42
/assign @Jiawei0227

@mattcary
Pass unknown labels in allowedTopologies during CSI translation
f0b34bd 
Change-Id: If90d6f4c4e6a5b5706fa255f058249b3c5a28e35
@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. sig/storage Categorizes an issue or PR as relevant to SIG Storage. release-note-none Denotes a PR that doesn't merit a release note. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 16, 2021
Jiawei0227
Jiawei0227 approved these changes Jul 19, 2021
View reviewed changes
Copy link
Contributor

@Jiawei0227 Jiawei0227 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

cc @msau42

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 19, 2021
@Jiawei0227
Copy link
Contributor

/retest

@msau42
Copy link
Member

msau42 commented Jul 19, 2021

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jiawei0227, mattcary, msau42

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 19, 2021
@k8s-ci-robot k8s-ci-robot merged commit bb817a9 into kubernetes:master Aug 5, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Aug 5, 2021
@mattcary mattcary mentioned this pull request Aug 6, 2021
Merged
@cpanato
Copy link
Member

cpanato commented Aug 16, 2021

/triage accepted
/priority important-soon

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Aug 16, 2021
k8s-ci-robot added a commit that referenced this pull request Aug 16, 2021
@k8s-ci-robot
Merge pull request #104198 from mattcary/automated-cherry-pick-of-#10…
8e42f35 
…3750-upstream-release-1.22

Automated cherry pick of #103750: Pass unknown labels in allowedTopologies during CSI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jiawei0227 Jiawei0227 Jiawei0227 approved these changes

@ddebroy ddebroy Awaiting requested review from ddebroy

@saad-ali saad-ali Awaiting requested review from saad-ali

Assignees

@Jiawei0227 Jiawei0227

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.

Unknown allowedTopologies cause an error for CSI Migration
5 participants
@mattcary @Jiawei0227 @msau42 @k8s-ci-robot @cpanato