Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize the for range code in types.go #103775

Merged
merged 1 commit into from
Aug 5, 2021
Merged

Optimize the for range code in types.go #103775

merged 1 commit into from
Aug 5, 2021

Conversation

jyz0309
Copy link
Contributor

@jyz0309 jyz0309 commented Jul 19, 2021

Signed-off-by: jyz0309 45495947@qq.com

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Optimize the for range code in types.go.
Just make the code clean.

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jul 19, 2021
@k8s-ci-robot k8s-ci-robot added sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 19, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @jyz0309. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Jul 19, 2021
@Huang-Wei
Copy link
Member

/ok-to-test

LGTM. Please squash the commits.

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 19, 2021
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/apiserver sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 20, 2021
@jyz0309 jyz0309 closed this Jul 20, 2021
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 20, 2021
@jyz0309
optimize the code
d05b232 
Signed-off-by: jyz0309 <45495947@qq.com>
@jyz0309 jyz0309 reopened this Jul 20, 2021
@jyz0309
Copy link
Contributor Author

jyz0309 commented Jul 20, 2021

/ok-to-test

LGTM. Please squash the commits.

Done. PTAL

@jyz0309
Copy link
Contributor Author

jyz0309 commented Jul 20, 2021

/retest-required

@jyz0309
Copy link
Contributor Author

jyz0309 commented Jul 20, 2021

@Huang-Wei All tests pass. PTAL~

@chendave
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 20, 2021
@k8s-ci-robot
Copy link
Contributor

@jyz0309: You must be a member of the kubernetes/milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your and have them propose you as an additional delegate for this responsibility.

In response to this:

/milestone v1.22

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@alculquicondor
Copy link
Member

@jyz0309 note that we are under code freeze. Your change will be merged next month. Thank you for your contribution.

@Huang-Wei
Copy link
Member

/approve
/milestone v1.23

@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Jul 20, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Huang-Wei, jyz0309

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 20, 2021
@fedebongio
Copy link
Contributor

/assign @caesarxuchao
/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jul 20, 2021
@alculquicondor
Copy link
Member

/remove-area apiserver
/remove-sig apimachinery

I'm not sure why this got tagged as such. This is just scheduler code.

@k8s-ci-robot
Copy link
Contributor

@alculquicondor: Those labels are not set on the issue: sig/apimachinery

In response to this:

/remove-area apiserver
/remove-sig apimachinery

I'm not sure why this got tagged as such. This is just scheduler code.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@alculquicondor
Copy link
Member

/remove-sig api-machinery

@k8s-ci-robot k8s-ci-robot removed the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Jul 20, 2021
@k8s-ci-robot k8s-ci-robot merged commit 3ee63b0 into kubernetes:master Aug 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alculquicondor alculquicondor Awaiting requested review from alculquicondor

@chendave chendave Awaiting requested review from chendave

Assignees

@caesarxuchao caesarxuchao

@chendave chendave

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@jyz0309 @k8s-ci-robot @Huang-Wei @chendave @alculquicondor @fedebongio @caesarxuchao