-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix kubectl version unit test #103955
Fix kubectl version unit test #103955
Conversation
@eddiezane: This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cc @brianpursley |
e88b484
to
207f7df
Compare
Signed-off-by: Eddie Zaneski <eddiezane@gmail.com>
207f7df
to
93ef5ac
Compare
/cc @knight42 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
This looks reasonable to me and I think this is the right way to address #102754.
/hold
@eddiezane just in case if you want others to review, please feel free to cancel the hold.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brianpursley, eddiezane, knight42 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/remove-hold |
What type of PR is this?
/kind failing-test
What this PR does / why we need it:
The
TestNewCmdVersionWithoutConfigFile
unit test currently relies on an API server. This causes the test to fail for developers that don't have a cluster configured.This PR swaps out the cmd factory for a testing one that does not provide a discovery client. This causes the external request bits to be skipped.
kubernetes/staging/src/k8s.io/kubectl/pkg/cmd/version/version.go
Lines 123 to 128 in d92b788
The external testing is currently accounted for in e2e tests.
Which issue(s) this PR fixes:
Fixes: #102754
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: